Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1403913005: Roll buildtools 5fc8d3943e..ef7f1f539c (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
Reviewers:
brettw, Bons
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 5fc8d3943e..ef7f1f539c In order to roll GN e8df8217dc..adf2cc6066 (r352082:r354085) and pick up the following changes: 027840d [GN]: support for loadable modules c8bcd19 Try again to fix the links in the GN README.md. 6222490 [GN]: Enable PCH for WebKit on Mac. b445e7c tools/gn: Remove code for forward_dependent_configs_from variable. cf0bd97 Restrict memory maps dump provider to only android and linux c96f78f Update tools/gn/README.md. d7e30d8 GN: Update documentation for updating the gn binaries (the rolling process). 3862a3e Fix another bug in the gn_roll script. cc637ee Make GN use_custom_libcxx work properly with sanitizers. TBR=andybons@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Committed: https://crrev.com/6f860a4a32a1f5a329121ae08463e4e4fa1b5753 Cr-Commit-Position: refs/heads/master@{#354119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
5 years, 2 months ago (2015-10-14 19:59:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403913005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403913005/1
5 years, 2 months ago (2015-10-14 19:59:36 UTC) #3
Dirk Pranke
5 years, 2 months ago (2015-10-14 20:15:10 UTC) #5
brettw
lgtm
5 years, 2 months ago (2015-10-14 21:40:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 21:40:14 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 21:41:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f860a4a32a1f5a329121ae08463e4e4fa1b5753
Cr-Commit-Position: refs/heads/master@{#354119}

Powered by Google App Engine
This is Rietveld 408576698