Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6841)

Unified Diff: chrome/browser/ui/webui/theme_source_unittest.cc

Issue 14039004: Add int params to URLDataSource::StartDataRequest(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/theme_source_unittest.cc
diff --git a/chrome/browser/ui/webui/theme_source_unittest.cc b/chrome/browser/ui/webui/theme_source_unittest.cc
index 66db279bdcfc5b1f2d0122d5cc8c734e5806a729..4f21862b3a031ec848e9dfdcaa328613b67f1357 100644
--- a/chrome/browser/ui/webui/theme_source_unittest.cc
+++ b/chrome/browser/ui/webui/theme_source_unittest.cc
@@ -25,8 +25,8 @@ class WebUISourcesTest : public testing::Test {
ThemeSource* theme_source() const { return theme_source_.get(); }
size_t result_data_size() const { return result_data_size_; }
- void StartDataRequest(const std::string& source, bool is_incognito) {
- theme_source()->StartDataRequest(source, is_incognito, callback_);
+ void StartDataRequest(const std::string& source) {
+ theme_source()->StartDataRequest(source, -1, -1, callback_);
}
size_t result_data_size_;
@@ -67,11 +67,11 @@ TEST_F(WebUISourcesTest, ThemeSourceMimeTypes) {
TEST_F(WebUISourcesTest, ThemeSourceImages) {
// We used to PNGEncode the images ourselves, but encoder differences
// invalidated that. We now just check that the image exists.
- StartDataRequest("IDR_THEME_FRAME_INCOGNITO", true);
+ StartDataRequest("IDR_THEME_FRAME_INCOGNITO");
size_t min = 0;
EXPECT_GT(result_data_size_, min);
- StartDataRequest("IDR_THEME_TOOLBAR", true);
+ StartDataRequest("IDR_THEME_TOOLBAR");
EXPECT_GT(result_data_size_, min);
}
@@ -84,13 +84,13 @@ TEST_F(WebUISourcesTest, ThemeSourceCSS) {
// just check for a successful request and data that is non-null.
size_t empty_size = 0;
- StartDataRequest("css/new_tab_theme.css", false);
+ StartDataRequest("css/new_tab_theme.css");
EXPECT_NE(result_data_size_, empty_size);
- StartDataRequest("css/new_tab_theme.css?pie", false);
+ StartDataRequest("css/new_tab_theme.css?pie");
EXPECT_NE(result_data_size_, empty_size);
// Check that we send NULL back when we can't find what we're looking for.
- StartDataRequest("css/WRONGURL", false);
+ StartDataRequest("css/WRONGURL");
EXPECT_EQ(result_data_size_, empty_size);
}

Powered by Google App Engine
This is Rietveld 408576698