build/common.gypi - Issue 1403893007: Adding third_party/openh264/src, build files and unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1403893007: Adding third_party/openh264/src, build files and unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename var to 'use_openh264', add OpenH264 to 'all' target of GN Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 67fc8e5b554a3bad4a41115cada9f3a0f95b4921..364d7adc300a8d3777e68381f3cb095cf8f4c6da 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1244,6 +1244,12 @@

'android_app_version_code%': '<(android_app_version_code)',

'enable_webvr%': '<(enable_webvr)',

+ # Enable this to build OpenH264.

+ # CHECK THE OPENH264 LICENSE BEFORE BUILDING. The default value should be 0,

+ # the open source version of Chromium should not build this by default due

+ # to license and patent reasons.

+ 'use_openh264%': 1,

# Turns on compiler optimizations in V8 in Debug build.

'v8_optimized_debug%': 1,

« no previous file with comments | « build/all.gyp ('k') | build/config/features.gni » ('j') | third_party/openh264/BUILD.gn » ('J')