third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 1403893003: Plumb gesture source value through Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 1403893003: Plumb gesture source value through Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments: never use uninitialized, track fling source device. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 75682ebad9b8c29359bc01bbd6fb1513359ab15c..03c87ddfb3ca1e5d873de9637a0103a13eb0f680 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -1612,7 +1612,7 @@ TEST_P(ParameterizedVisualViewportTest, SlowScrollAfterImplScroll)

IntPoint(0, 0),

IntSize(5, 5),

- 0, PlatformEvent::NoModifiers);

+ 0, PlatformEvent::NoModifiers, PlatformGestureSourceTouchpad);

gsu.setScrollGestureData(-50, -60, 1, 1, false, false, -1 /* null plugin id */);

frame()->eventHandler().handleGestureEvent(gsu);

@@ -1738,6 +1738,7 @@ TEST_P(ParameterizedVisualViewportTest, PinchZoomGestureScrollsVisualViewportOnl

WebGestureEvent pinchUpdate;

pinchUpdate.type = WebInputEvent::GesturePinchUpdate;

+ pinchUpdate.sourceDevice = WebGestureDeviceTouchpad;

pinchUpdate.x = 100;

pinchUpdate.y = 100;

pinchUpdate.data.pinchUpdate.scale = 2;