third_party/WebKit/Source/web/WebViewImpl.h - Issue 1403893003: Plumb gesture source value through Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1403893003: Plumb gesture source value through Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments: never use uninitialized, track fling source device. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.h

diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h

index a1f3e54a41ca48ffe7ea4c4cfac460140615abbf..d484863e1d96a21a22c0195dc3a4fbde1ea03dd6 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.h

+++ b/third_party/WebKit/Source/web/WebViewImpl.h

@@ -733,7 +733,7 @@ private:

WebPoint m_positionOnFlingStart;

WebPoint m_globalPositionOnFlingStart;

int m_flingModifier;

- bool m_flingSourceDevice;

+ WebGestureDevice m_flingSourceDevice;

Vector<OwnPtr<LinkHighlightImpl>> m_linkHighlights;

OwnPtr<WebCompositorAnimationTimeline> m_linkHighlightsTimeline;

OwnPtrWillBePersistent<FullscreenController> m_fullscreenController;