content/browser/renderer_host/render_widget_host_impl.cc - Issue 1403893003: Plumb gesture source value through Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1403893003: Plumb gesture source value through Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments: never use uninitialized, track fling source device. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index 512dfee75fcfe859870524425f795d18b164b4aa..a05304af2682598e795b5b3a53e87a7294243ad5 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -141,6 +141,7 @@ inline blink::WebGestureEvent CreateScrollBeginForWrapping(

blink::WebGestureEvent wrap_gesture_scroll_begin;

wrap_gesture_scroll_begin.type = blink::WebInputEvent::GestureScrollBegin;

+ wrap_gesture_scroll_begin.sourceDevice = gesture_event.sourceDevice;

wrap_gesture_scroll_begin.data.scrollBegin.deltaXHint = 0;

wrap_gesture_scroll_begin.data.scrollBegin.deltaYHint = 0;

wrap_gesture_scroll_begin.resendingPluginId = gesture_event.resendingPluginId;

@@ -154,6 +155,7 @@ inline blink::WebGestureEvent CreateScrollEndForWrapping(

blink::WebGestureEvent wrap_gesture_scroll_end;

wrap_gesture_scroll_end.type = blink::WebInputEvent::GestureScrollEnd;

+ wrap_gesture_scroll_end.sourceDevice = gesture_event.sourceDevice;

wrap_gesture_scroll_end.resendingPluginId = gesture_event.resendingPluginId;

return wrap_gesture_scroll_end;