third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp - Issue 1403893003: Plumb gesture source value through Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

Issue 1403893003: Plumb gesture source value through Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing sourceDevice initialization in EventSender. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('K') | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/public/platform/WebGestureDevice.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

index 3b9a157531d89d8781c190da6fc1e8fe4b6a8c6b..fd22d785fcb76e21bdc10fb9dfeea837f2d062bc 100644

--- a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

@@ -433,7 +433,7 @@ TEST(WebInputEventConversionTest, InputEventsScaling)

{

PlatformGestureEvent platformGestureEvent(PlatformEvent::GestureScrollUpdate, IntPoint(10, 12), IntPoint(20, 22), IntSize(25, 27), 0,

- PlatformEvent::NoModifiers);

+ PlatformEvent::NoModifiers, PlatformGestureSourceTouchscreen);

platformGestureEvent.setScrollGestureData(30, 32, 40, 42, true, true, -1 /* null plugin id */);

// FIXME: GestureEvent does not preserve velocityX, velocityY,

// or preventPropagation. It also fails to scale

@@ -453,6 +453,7 @@ TEST(WebInputEventConversionTest, InputEventsScaling)

EXPECT_EQ(0, webGestureBuilder.data.scrollUpdate.velocityY);

EXPECT_TRUE(webGestureBuilder.data.scrollUpdate.inertial);

EXPECT_FALSE(webGestureBuilder.data.scrollUpdate.preventPropagation);

+ EXPECT_EQ(WebGestureDeviceTouchscreen, webGestureBuilder.sourceDevice);

}

{