Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1403893003: Plumb gesture source value through Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make compilers happy. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 6ccabebaf585749882754bfb8139c8719d6095a9..064515182c934f42cde6f6ceecbba5349286904a 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -1601,7 +1601,7 @@ TEST_F(WebFrameTest, SetForceZeroLayoutHeightWorksWithRelayoutsWhenHeightChanged
ASSERT_NE(nullptr, element);
EXPECT_EQ(String("oldValue"), element->innerText());
- PlatformGestureEvent gestureEvent(PlatformEvent::Type::GestureTap, hitPoint, hitPoint, IntSize(0, 0), 0, PlatformEvent::NoModifiers);
+ PlatformGestureEvent gestureEvent(PlatformEvent::Type::GestureTap, hitPoint, hitPoint, IntSize(0, 0), 0, PlatformEvent::NoModifiers, PlatformGestureSourceTouchpad);
webViewHelper.webViewImpl()->mainFrameImpl()->frame()->eventHandler().handleGestureEvent(gestureEvent);
// when pressed, the button changes its own text to "updatedValue"
EXPECT_EQ(String("updatedValue"), element->innerText());
@@ -4759,6 +4759,7 @@ static WebGestureEvent fatTap(int x, int y)
{
WebGestureEvent event;
event.type = WebInputEvent::GestureTap;
+ event.sourceDevice = WebGestureDeviceTouchpad;
event.x = x;
event.y = y;
event.data.tap.width = 50;
@@ -7956,6 +7957,7 @@ protected:
{
WebGestureEvent event;
event.type = type;
+ event.sourceDevice = WebGestureDeviceTouchpad;
event.x = 100;
event.y = 100;
if (type == WebInputEvent::GestureScrollUpdate) {

Powered by Google App Engine
This is Rietveld 408576698