Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: net/socket/ssl_client_socket_openssl.h

Issue 1403863002: Enable exporting SSLKEYLOGFILE on Android w/ command line arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: openssl envrironment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_openssl.h
diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h
index 228214b42d6e2f5b925050f976a5a8274c0171c2..ef03e2b7d8b134f8d0a795e5a3774de76361bf9f 100644
--- a/net/socket/ssl_client_socket_openssl.h
+++ b/net/socket/ssl_client_socket_openssl.h
@@ -16,6 +16,7 @@
#include "base/memory/weak_ptr.h"
#include "net/base/completion_callback.h"
#include "net/base/io_buffer.h"
+#include "net/base/net_export.h"
#include "net/cert/cert_verifier.h"
#include "net/cert/cert_verify_result.h"
#include "net/cert/ct_verify_result.h"
@@ -36,7 +37,7 @@ class SSLInfo;
class SSLPrivateKey;
// An SSL client socket implemented with OpenSSL.
-class SSLClientSocketOpenSSL : public SSLClientSocket {
+class NET_EXPORT SSLClientSocketOpenSSL : public SSLClientSocket {
public:
// Takes ownership of the transport_socket, which may already be connected.
// The given hostname will be compared with the name(s) in the server's
@@ -53,6 +54,9 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {
return ssl_session_cache_shard_;
}
+ // Export ssl key log files if env variable is not set.
+ static void SetSslKeyLogFile(std::string ssl_keylog_file);
Bryan McQuade 2015/10/14 00:38:54 nit: since other names use 'SSL' in all caps, let'
Bryan McQuade 2015/10/14 00:38:54 if there's not a strong need to use std::string he
Zhongyi Shi 2015/10/15 00:26:52 Done.
Zhongyi Shi 2015/10/15 00:26:52 Just to keep consistent with the usage in this fil
+
// SSLClientSocket implementation.
void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) override;
NextProtoStatus GetNextProto(std::string* proto) const override;

Powered by Google App Engine
This is Rietveld 408576698