Enable exporting SSLKEYLOGFILE on Android w/ command line arguments

net/socket/ssl_client_socket_openssl.h

Index: net/socket/ssl_client_socket_openssl.h
diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h
index 228214b42d6e2f5b925050f976a5a8274c0171c2..ec9991e362bae52e2e20c7ce4ee1133c78208825 100644
--- a/net/socket/ssl_client_socket_openssl.h
+++ b/net/socket/ssl_client_socket_openssl.h
@@ -16,6 +16,7 @@
 #include "base/memory/weak_ptr.h"
 #include "net/base/completion_callback.h"
 #include "net/base/io_buffer.h"
+#include "net/base/net_export.h"
 #include "net/cert/cert_verifier.h"
 #include "net/cert/cert_verify_result.h"
 #include "net/cert/ct_verify_result.h"
@@ -36,7 +37,7 @@ class SSLInfo;
 class SSLPrivateKey;
 
 // An SSL client socket implemented with OpenSSL.
-class SSLClientSocketOpenSSL : public SSLClientSocket {
+class NET_EXPORT SSLClientSocketOpenSSL : public SSLClientSocket {

[Bryan McQuade, 2015/10/15 01:05:26]

do you still need to NET_EXPORT now that this gets invoked only by
SSLClientSocket? I'm new to this codebase, so I'm not sure, but think we should
avoid NET_EXPORT here if we can.

[Zhongyi Shi, 2015/10/15 02:02:04]

We no looger need the NET_EXPORT, as the it's not used outside the //net stack.

  public:
   // Takes ownership of the transport_socket, which may already be connected.
   // The given hostname will be compared with the name(s) in the server's
@@ -53,6 +54,9 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {
     return ssl_session_cache_shard_;
   }
 
+  // Export ssl key log files if env variable is not set.
+  static void SetSSLKeyLogFile(std::string ssl_keylog_file);

[Bryan McQuade, 2015/10/15 01:05:26]

same - 'const std::string&' rather than 'std::string'

[Zhongyi Shi, 2015/10/15 02:02:04]

Done.

+
   // SSLClientSocket implementation.
   void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) override;
   NextProtoStatus GetNextProto(std::string* proto) const override;