Enable exporting SSLKEYLOGFILE on Android w/ command line arguments

chrome/browser/io_thread.cc

Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 952964b1b79a7b16d32de582d06b4334a6b7086f..0e898fefad768c80ba33f0cc757e594873babaac 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -12,6 +12,7 @@
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/debug/leak_tracker.h"
+#include "base/environment.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_registry_simple.h"
@@ -80,6 +81,7 @@
 #include "net/quic/crypto/crypto_protocol.h"
 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_utils.h"
+#include "net/socket/ssl_client_socket_openssl.h"
 #include "net/socket/tcp_client_socket.h"
 #include "net/spdy/spdy_session.h"
 #include "net/ssl/channel_id_service.h"
@@ -553,6 +555,13 @@ void IOThread::Init() {
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
 
+  if (command_line.HasSwitch(switches::kSSLKeyLogFile)) {
+    scoped_ptr<base::Environment> env(base::Environment::Create());
+    std::string switch_value = command_line.GetSwitchValueNative(
+                                              switches::kSSLKeyLogFile);
+    env->SetVar("SSLKEYLOGFILE", switch_value);

[Bryan McQuade, 2015/10/13 14:33:36]

Thanks for putting this patch together!

I don't know this code well, but it seems like it might be better to not use the
base::Environment instance as a means for passing this down.

davidben had suggested: "ideally this would work as some parameter hanging off
the HttpNetworkSession or something else that gets routed into the SSL_CTX from
BoringSSL".

It's not clear to me how to push this information down to where it's needed
though. The logic to set up the SSL_CTX is in the
SSLClientSocketOpenSSL::SSLContext singleton which is private to the
SSLClientSocketOpenSSL implementation.

The most direct way might be to add a 'static void SetSslKeyLogFile(const char*
filename);' to SSLClientSocketOpenSSL which could push this into the singleton
SSLClientSocketOpenSSL::SSLContext instance.

We could also add a 'string ssl_key_log_file' param to
HttpNetworkSession::Params, and then push down the HttpNetworkSession or
SSLClientSocketOpenSSL::SSLContext::Params to a static method on
SSLClientSocketOpenSSL responsible for pushing the relevant config info into
SSLClientSocketOpenSSL::SSLContext. I'm not familiar enough with the code to
know if this is desirable or if there's a good way to do that.

David, can you give guidance here? What's the best way to plumb this string
value down to the SSLContext singleton instance?

[davidben, 2015/10/13 16:07:39]

I think something on HttpNetworkSession::Params is, long-term, desirable.
(Probably not a string because we want all out HttpNetworkSessions to write to
one file, so some kind of SSLKeyLogger object.)

But we can't do that while SSL_CTX is on a singleton. I mean to fix that at some
point but haven't yet. So in the meantime, I think the static method on
SSLClientSocketOpenSSL is the way to go.

+  }
+
   DCHECK(!globals_);
   globals_ = new Globals;