Enable exporting SSLKEYLOGFILE on Android w/ command line arguments

chrome/browser/io_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/io_thread.h"
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/debug/leak_tracker.h"
+#include "base/environment.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
@@ skipping 48 matching lines @@
 #include "net/http/http_auth_filter.h"
 #include "net/http/http_auth_handler_factory.h"
 #include "net/http/http_network_layer.h"
 #include "net/http/http_server_properties_impl.h"
 #include "net/proxy/proxy_config_service.h"
 #include "net/proxy/proxy_script_fetcher_impl.h"
 #include "net/proxy/proxy_service.h"
 #include "net/quic/crypto/crypto_protocol.h"
 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_utils.h"
+#include "net/socket/ssl_client_socket_openssl.h"
 #include "net/socket/tcp_client_socket.h"
 #include "net/spdy/spdy_session.h"
 #include "net/ssl/channel_id_service.h"
 #include "net/ssl/default_channel_id_store.h"
 #include "net/url_request/data_protocol_handler.h"
 #include "net/url_request/file_protocol_handler.h"
 #include "net/url_request/ftp_protocol_handler.h"
 #include "net/url_request/static_http_user_agent_settings.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_backoff_manager.h"
@@ skipping 453 matching lines @@
 #endif
 
   // TODO(erikchen): Remove ScopedTracker below once http://crbug.com/466432
   // is fixed.
   tracked_objects::ScopedTracker tracking_profile2(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "466432 IOThread::InitAsync::CommandLineForCurrentProcess"));
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
 
+  if (command_line.HasSwitch(switches::kSSLKeyLogFile)) {
+    scoped_ptr<base::Environment> env(base::Environment::Create());
+    std::string switch_value = command_line.GetSwitchValueNative(
+                                              switches::kSSLKeyLogFile);
+    env->SetVar("SSLKEYLOGFILE", switch_value);

[Bryan McQuade, 2015/10/13 14:33:36]

Thanks for putting this patch together!

I don't know this code well, but it seems like it might be better to not use the
base::Environment instance as a means for passing this down.

davidben had suggested: "ideally this would work as some parameter hanging off
the HttpNetworkSession or something else that gets routed into the SSL_CTX from
BoringSSL".

It's not clear to me how to push this information down to where it's needed
though. The logic to set up the SSL_CTX is in the
SSLClientSocketOpenSSL::SSLContext singleton which is private to the
SSLClientSocketOpenSSL implementation.

The most direct way might be to add a 'static void SetSslKeyLogFile(const char*
filename);' to SSLClientSocketOpenSSL which could push this into the singleton
SSLClientSocketOpenSSL::SSLContext instance.

We could also add a 'string ssl_key_log_file' param to
HttpNetworkSession::Params, and then push down the HttpNetworkSession or
SSLClientSocketOpenSSL::SSLContext::Params to a static method on
SSLClientSocketOpenSSL responsible for pushing the relevant config info into
SSLClientSocketOpenSSL::SSLContext. I'm not familiar enough with the code to
know if this is desirable or if there's a good way to do that.

David, can you give guidance here? What's the best way to plumb this string
value down to the SSLContext singleton instance?

[davidben, 2015/10/13 16:07:39]

I think something on HttpNetworkSession::Params is, long-term, desirable.
(Probably not a string because we want all out HttpNetworkSessions to write to
one file, so some kind of SSLKeyLogger object.)

But we can't do that while SSL_CTX is on a singleton. I mean to fix that at some
point but haven't yet. So in the meantime, I think the static method on
SSLClientSocketOpenSSL is the way to go.

+  }
+
   DCHECK(!globals_);
   globals_ = new Globals;
 
   // Add an observer that will emit network change events to the ChromeNetLog.
   // Assuming NetworkChangeNotifier dispatches in FIFO order, we should be
   // logging the network change before other IO thread consumers respond to it.
   network_change_observer_.reset(
       new LoggingNetworkChangeObserver(net_log_));
 
   // Setup the HistogramWatcher to run on the IO thread.
@@ skipping 1026 matching lines @@
   globals->proxy_script_fetcher_url_request_job_factory = job_factory.Pass();
 
   context->set_job_factory(
       globals->proxy_script_fetcher_url_request_job_factory.get());
 
   // TODO(rtenneti): We should probably use HttpServerPropertiesManager for the
   // system URLRequestContext too. There's no reason this should be tied to a
   // profile.
   return context;
 }