tools/metrics/actions/extract_actions.py - Issue 1403833002: Material PDF: Add metrics to count usage of PDF title and bookmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/actions/extract_actions.py

Issue 1403833002: Material PDF: Add metrics to count usage of PDF title and bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove braces Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/metrics/actions/extract_actions.py

diff --git a/tools/metrics/actions/extract_actions.py b/tools/metrics/actions/extract_actions.py

index 218c8f2afd2e26b6d7e9d345c651543859422a11..320b3cfe1077bfe3311ab1111b527e3b12cee2b2 100755

--- a/tools/metrics/actions/extract_actions.py

+++ b/tools/metrics/actions/extract_actions.py

@@ -191,8 +191,8 @@ def AddWebKitEditorActions(actions):

if match: # Plain call to RecordAction

actions.add(match.group(1))

-def AddClosedSourceActions(actions):

- """Add actions that are in code which is not checked out by default

+def AddPDFPluginActions(actions):

+ """Add actions that are sent by the PDF plugin.

Arguments

actions: set of actions to add to.

@@ -740,9 +740,9 @@ def UpdateXml(original_xml):

AddAutomaticResetBannerActions(actions)

AddBookmarkManagerActions(actions)

AddChromeOSActions(actions)

- AddClosedSourceActions(actions)

AddExtensionActions(actions)

AddHistoryPageActions(actions)

+ AddPDFPluginActions(actions)

return PrettyPrint(actions, actions_dict, comment_nodes)

« no previous file with comments | « pdf/out_of_process_instance.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')