chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OverlayPanelContentFactory.java - Issue 1403813003: [Contextual Search] Fixes ContentView regressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OverlayPanelContentFactory.java

Issue 1403813003: [Contextual Search] Fixes ContentView regressions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add TODO as per offline chat with mdjones@ Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/ContextualSearchLayout.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OverlayPanelContentFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OverlayPanelContentFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OverlayPanelContentFactory.java

new file mode 100644

index 0000000000000000000000000000000000000000..52bf1c149259f42440dbd13d211914f5f69bc92b

--- /dev/null

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OverlayPanelContentFactory.java

@@ -0,0 +1,18 @@

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+package org.chromium.chrome.browser.compositor.bottombar.contextualsearch;

+import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelContent;

+/**

+ * Interface used to generalize the creation of the OverlayPanelContent. This is so test cases

+ * are able to offer a custom version of the OverlayPanelContent to be used in the tests.

+ */

+public interface OverlayPanelContentFactory {

+ /**

+ * Create a new OverlayPanelContent object. This can be overridden for tests.

+ */

+ OverlayPanelContent createNewOverlayPanelContent();