Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1403813002: Enable optimization when compiling for NaCl with GN (Closed)

Created:
5 years, 2 months ago by Sergey Ulanov
Modified:
5 years, 2 months ago
Reviewers:
fbarchard
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Enable optimization when compiling for NaCl with GN PNaCl code validation fails when compiling with -O0 due to the linked bug. Always enable optimization when compiling for NaCl to workaround this bug. BUG=538243 R=fbarchard@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/41c6cc7eb9f0208321ae0f9134a26a34bd31af37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Sergey Ulanov
5 years, 2 months ago (2015-10-12 21:46:30 UTC) #2
fbarchard
lgtm
5 years, 2 months ago (2015-10-12 21:50:24 UTC) #4
fbarchard1
5 years, 2 months ago (2015-10-12 21:52:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41c6cc7eb9f0208321ae0f9134a26a34bd31af37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698