Add metrics for window.external.AddSearchProvider and

chrome/renderer/external_extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/external_extension.h"
 
 #include "chrome/common/render_messages.h"
 #include "chrome/common/search_provider.h"
+#include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #include "v8/include/v8.h"
 
 using blink::WebLocalFrame;
 using blink::WebView;
 using content::RenderView;
 
@@ skipping 90 matching lines @@
   RenderView* render_view = GetRenderView();
   if (!render_view)
     return;
 
   WebLocalFrame* webframe = WebLocalFrame::frameForCurrentContext();
   if (!webframe)
     return;
 
   GURL osdd_url = GURL(webframe->document().url()).Resolve(osdd_string);
   if (!osdd_url.is_empty() && osdd_url.is_valid()) {
+    content::RenderThread::Get()->RecordAction(
+        base::UserMetricsAction("window.external.AddSearchProvider"));
     render_view->Send(new ChromeViewHostMsg_PageHasOSDD(
         render_view->GetRoutingID(), webframe->document().url(), osdd_url,
         search_provider::EXPLICIT_PROVIDER));
   }
 }
 
 // static
 void ExternalExtensionWrapper::IsSearchProviderInstalled(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   if (!args.Length() || !args[0]->IsString())
     return;
 
   v8::String::Utf8Value utf8name(args[0]);
   if (!utf8name.length())
     return;
 
   std::string name(*utf8name);
   RenderView* render_view = GetRenderView();
   if (!render_view)
     return;
 
   WebLocalFrame* webframe = WebLocalFrame::frameForCurrentContext();
   if (!webframe)
     return;
 
   search_provider::InstallState install = search_provider::DENIED;
   GURL inquiry_url = GURL(webframe->document().url()).Resolve(name);
   if (!inquiry_url.is_empty()) {
-      render_view->Send(new ChromeViewHostMsg_GetSearchProviderInstallState(
-          render_view->GetRoutingID(),
-          webframe->document().url(),
-          inquiry_url,
-          &install));
+    content::RenderThread::Get()->RecordAction(
+        base::UserMetricsAction("window.external.IsSearchProviderInstalled"));
+    render_view->Send(new ChromeViewHostMsg_GetSearchProviderInstallState(
+        render_view->GetRoutingID(),
+        webframe->document().url(),
+        inquiry_url,
+        &install));
   }
 
   if (install == search_provider::DENIED) {
     // FIXME: throw access denied exception.
     v8::Isolate* isolate = args.GetIsolate();
     isolate->ThrowException(v8::Exception::Error(v8::String::Empty(isolate)));
     return;
   }
+
+  content::RenderThread::Get()->RecordAction(
+      base::UserMetricsAction("window.external.IsSearchProviderInstalled_success"));

[Peter Kasting, 2015/10/13 18:36:20]

80 columns

[Evan Stade, 2015/10/13 18:40:57]

I don't think I can because of this comment[1], unless I reduce the indentation.

[1]
  // WARNING: When using base::UserMetricsAction, base::UserMetricsAction
  // and a string literal parameter must be on the same line, e.g.
  //   RenderThread::Get()->RecordAction(
  //       base::UserMetricsAction("my extremely long action name"));
  // because otherwise our processing scripts won't pick up on new actions.

[Peter Kasting, 2015/10/13 19:01:41]

Based on extract_actions.py line 53, I think this comment is incorrect.  You
should check to be sure, but I think the right thing to do is to remove or
modify that comment and rewrap your code.

   args.GetReturnValue().Set(static_cast<int32_t>(install));
 }
 
 v8::Extension* ExternalExtension::Get() {
   return new ExternalExtensionWrapper();
 }
 
 }  // namespace extensions_v8