Ensure that DataPipeProducerDispatcher::CreateEquivalentDispatcherAndCloseImplNoLock serializes the…

Ensure that DataPipeProducerDispatcher::CreateEquivalentDispatcherAndCloseImplNoLock serializes the object.

Otherwise the channel_ is only serialized later in EndSerializeAndCloseImplNoLock. In between those two calls, if the consumer is closed the channel_ can call the old and destructed DataPipeProducerDispatcher.

BUG=478251
Committed: https://crrev.com/c382820df017db1bc9d53ac1d745d4e688d94efd
Cr-Commit-Position: refs/heads/master@{#353914}

[jam, 2015-10-13 14:59:43]

jam@chromium.org changed reviewers:
+ yzshen@chromium.org

[jam, 2015-10-13 15:00:34]

This is hard to test because it's a race condition. However it does come up in
the page cycler.

In the meantime, I added a test for sending a producer, which we didn't have
before.

[yzshen1, 2015-10-13 16:17:41]

lgtm

https://codereview.chromium.org/1403773005/diff/20001/mojo/edk/system/data_pi...
File mojo/edk/system/data_pipe_unittest.cc (right):

https://codereview.chromium.org/1403773005/diff/20001/mojo/edk/system/data_pi...
mojo/edk/system/data_pipe_unittest.cc:16: #include "mojo/public/c/system/core.h"
nit: I think if we include core.h we probably don't need to include other
c/system/* files. Because core.h is a list of those c/system/* files.

[jam, 2015-10-13 16:34:06]

https://codereview.chromium.org/1403773005/diff/20001/mojo/edk/system/data_pi...
File mojo/edk/system/data_pipe_unittest.cc (right):

https://codereview.chromium.org/1403773005/diff/20001/mojo/edk/system/data_pi...
mojo/edk/system/data_pipe_unittest.cc:16: #include "mojo/public/c/system/core.h"
On 2015/10/13 16:17:41, yzshen1 wrote:
> nit: I think if we include core.h we probably don't need to include other
> c/system/* files. Because core.h is a list of those c/system/* files.

switched to just including message_pipe.h

[jam, 2015-10-13 16:34:27]

The CQ bit was checked by jam@chromium.org

[jam, 2015-10-13 16:34:27]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1403773005/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-10-13 16:38:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403773005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403773005/40001

[commit-bot: I haz the power, 2015-10-13 16:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 16:46:00]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jam, 2015-10-13 19:18:40]

The CQ bit was checked by jam@chromium.org

[jam, 2015-10-13 19:18:40]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1403773005/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2015-10-13 19:19:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403773005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403773005/60001

[commit-bot: I haz the power, 2015-10-13 22:28:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 22:28:41]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[jam, 2015-10-13 22:36:38]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-10-13 22:39:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403773005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403773005/60001

[commit-bot: I haz the power, 2015-10-14 00:00:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-14 00:01:16]

Patchset 4 (id:??) landed as
https://crrev.com/c382820df017db1bc9d53ac1d745d4e688d94efd
Cr-Commit-Position: refs/heads/master@{#353914}