Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1403773004: [Service Workers] Follow-up CL for DCHECK from WebServiceWorkerResponse. (Closed)

Created:
5 years, 2 months ago by Pritam Nikam
Modified:
5 years, 2 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Service Workers] Follow-up CL for DCHECK from WebServiceWorkerResponse. This patch is a follow-up CL: https://codereview.chromium.org/1372423002/#msg15 BUG=537127 Committed: https://crrev.com/7748cc8e1ec3d781acd46c978a2a453cc199402d Cr-Commit-Position: refs/heads/master@{#354459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/serviceworker/iso-latin1-header.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/iso-latin1-header-iframe.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Pritam Nikam
Hi all, This patch is a follow-up CL: https://codereview.chromium.org/1372423002/#msg15 PTAL, Thanks!
5 years, 2 months ago (2015-10-15 05:45:59 UTC) #3
horo
lgtm
5 years, 2 months ago (2015-10-16 02:15:32 UTC) #4
Pritam Nikam
On 2015/10/16 02:15:32, horo wrote: > lgtm Thanks horo :) I'll go ahead with commit ...
5 years, 2 months ago (2015-10-16 05:06:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403773004/1
5 years, 2 months ago (2015-10-16 05:06:14 UTC) #7
tyoshino (SeeGerritForStatus)
lgtm
5 years, 2 months ago (2015-10-16 06:16:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 06:30:24 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 06:31:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7748cc8e1ec3d781acd46c978a2a453cc199402d
Cr-Commit-Position: refs/heads/master@{#354459}

Powered by Google App Engine
This is Rietveld 408576698