Fix VPN connected logic in internet settings

Fix VPN connected logic in internet settings

This CL:
* Fixes the logic that updates 'deviceStates' to avoid an incorrect
  intermediate state.
* Adds a defaultNetwork property allowing the details page to check
  that a default network exists to enable 'connect' for VPN.
* Updates the enabled logic for the connect button for VPN

BUG=521040
Committed: https://crrev.com/3898090598bbe95bc2040b4c0ac33fc012fe6f75
Cr-Commit-Position: refs/heads/master@{#356324}

[stevenjb, 2015-10-13 18:14:16]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2015-10-26 20:41:42]

lgtm w/ optional suggestions

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_page.js (right):

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_page.js:37:
defaultNetwork: {
defaultNetwork is already explained in network-summary and
settings-internet-detail-page. Personally I would omit it here since we don't
need it in the JS.

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_summary.js (right):

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary.js:296:
getNetworkStates_: function(deviceStates) {
Maybe make this opt_deviceStates (@param {Array<!DSP>|undefined}), so it can be
called as getNetworkStates_()?

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary.js:302: var self
= this;
we mostly/only use .bind(this) instead of var foo = this...

[stevenjb, 2015-10-27 16:49:50]

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_page.js (right):

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_page.js:37:
defaultNetwork: {
On 2015/10/26 20:41:41, michaelpg wrote:
> defaultNetwork is already explained in network-summary and
> settings-internet-detail-page. Personally I would omit it here since we don't
> need it in the JS.

I forgot that we can have "anonymous" properties. Done.

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_summary.js (right):

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary.js:296:
getNetworkStates_: function(deviceStates) {
On 2015/10/26 20:41:42, michaelpg wrote:
> Maybe make this opt_deviceStates (@param {Array<!DSP>|undefined}), so it can
be
> called as getNetworkStates_()?

Done.

https://codereview.chromium.org/1403773002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary.js:302: var self
= this;
On 2015/10/26 20:41:41, michaelpg wrote:
> we mostly/only use .bind(this) instead of var foo = this...

Done.

[stevenjb, 2015-10-27 16:55:32]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2015-10-27 16:55:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1403773002/#ps60001
(title: "Make closure happy")

[commit-bot: I haz the power, 2015-10-27 16:56:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403773002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403773002/60001

[commit-bot: I haz the power, 2015-10-27 17:19:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-27 17:20:29]

Patchset 4 (id:??) landed as
https://crrev.com/3898090598bbe95bc2040b4c0ac33fc012fe6f75
Cr-Commit-Position: refs/heads/master@{#356324}