Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: runtime/vm/isolate.h

Issue 1403693002: - Implement package map parameter when spawning isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 47a36fbd3b4251964f272155722dbb848383df9f..81cca495518caab8efb55c7c605a921ee2056585 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -1032,6 +1032,7 @@ class IsolateSpawnState {
IsolateSpawnState(Dart_Port parent_port,
const char* script_url,
const char* package_root,
+ const char** package_map,
const Instance& args,
const Instance& message,
bool paused,
@@ -1046,11 +1047,12 @@ class IsolateSpawnState {
Dart_Port parent_port() const { return parent_port_; }
Dart_Port on_exit_port() const { return on_exit_port_; }
Dart_Port on_error_port() const { return on_error_port_; }
- char* script_url() const { return script_url_; }
- char* package_root() const { return package_root_; }
- char* library_url() const { return library_url_; }
- char* class_name() const { return class_name_; }
- char* function_name() const { return function_name_; }
+ const char* script_url() const { return script_url_; }
+ const char* package_root() const { return package_root_; }
+ const char** package_map() const { return package_map_; }
+ const char* library_url() const { return library_url_; }
+ const char* class_name() const { return class_name_; }
+ const char* function_name() const { return function_name_; }
bool is_spawn_uri() const { return library_url_ == NULL; }
bool paused() const { return paused_; }
bool errors_are_fatal() const { return errors_are_fatal_; }
@@ -1066,11 +1068,12 @@ class IsolateSpawnState {
Dart_Port parent_port_;
Dart_Port on_exit_port_;
Dart_Port on_error_port_;
- char* script_url_;
- char* package_root_;
- char* library_url_;
- char* class_name_;
- char* function_name_;
+ const char* script_url_;
+ const char* package_root_;
+ const char** package_map_;
+ const char* library_url_;
+ const char* class_name_;
+ const char* function_name_;
uint8_t* serialized_args_;
intptr_t serialized_args_len_;
uint8_t* serialized_message_;
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698