Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: runtime/include/dart_api.h

Issue 1403693002: - Implement package map parameter when spawning isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix typo in comment. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/include/dart_api.h
diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h
index c565895143f4917aa1ada80de7afee8c7542d106..c8d9c38cb852a613e938a2fbdadd5e2e5aa48c6f 100755
--- a/runtime/include/dart_api.h
+++ b/runtime/include/dart_api.h
@@ -755,8 +755,13 @@ typedef struct {
* improve debugging messages. The main function is not invoked by
* this function.
* \param package_root The package root path for this isolate to resolve
- * package imports against. If this parameter is NULL, the package root path
- * of the parent isolate should be used.
+ * package imports against. Only one of package_root and package_map
+ * parameters is non-NULL. If neither parameter is passed the package
+ * resolution of the parent isolate should be used.
+ * \param package_map The package map for this isolate to resolve package
+ * imports against. Only one of package_root and package_map
+ * parameters is non-NULL. If neither parameter is passed the package
+ * resolution of the parent isolate should be used.
Lasse Reichstein Nielsen 2015/10/12 09:34:44 May want to specify that it's represented as alter
Ivan Posva 2015/10/12 16:05:22 Done.
* \param flags Default flags for this isolate being spawned. Either inherited
* from the spawning isolate or passed as parameters when spawning the
* isolate from Dart code.
@@ -771,6 +776,7 @@ typedef struct {
typedef Dart_Isolate (*Dart_IsolateCreateCallback)(const char* script_uri,
const char* main,
const char* package_root,
+ const char** package_map,
Dart_IsolateFlags* flags,
void* callback_data,
char** error);

Powered by Google App Engine
This is Rietveld 408576698