Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1403683003: [es6] Stage --harmony-completion. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Stage --harmony-completion. R=rossberg BUG= Committed: https://crrev.com/f113f3c3844ae8962a7322f45b90e693e4551635 Cr-Commit-Position: refs/heads/master@{#31209}

Patch Set 1 #

Patch Set 2 : Adapt test262. #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : Rebase... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/flag-definitions.h View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
neis
5 years, 2 months ago (2015-10-12 10:52:52 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-10-12 10:55:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403683003/1
5 years, 2 months ago (2015-10-12 10:56:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/10503)
5 years, 2 months ago (2015-10-12 11:11:28 UTC) #6
neis
On 2015/10/12 11:11:28, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-10-12 11:43:19 UTC) #7
rossberg
lgtm https://codereview.chromium.org/1403683003/diff/20001/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/1403683003/diff/20001/test/test262/test262.status#newcode728 test/test262/test262.status:728: # https://bugs.ecmascript.org/show_bug.cgi?id=4540 Maybe a short sentence what we ...
5 years, 2 months ago (2015-10-12 11:50:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403683003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403683003/40001
5 years, 2 months ago (2015-10-12 12:05:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/8795) v8_linux_dbg on tryserver.v8 (JOB_FAILED, ...
5 years, 2 months ago (2015-10-12 12:06:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403683003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403683003/60001
5 years, 2 months ago (2015-10-12 12:11:19 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-12 12:36:36 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 12:36:57 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f113f3c3844ae8962a7322f45b90e693e4551635
Cr-Commit-Position: refs/heads/master@{#31209}

Powered by Google App Engine
This is Rietveld 408576698