Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: content/browser/quota/quota_database_unittest.cc

Issue 1403673002: Add Quota.TimeSinceOriginEvicted UMA histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix histogram comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/quota/quota_database_unittest.cc
diff --git a/content/browser/quota/quota_database_unittest.cc b/content/browser/quota/quota_database_unittest.cc
index 84af01707c26e7af10a991cb39ec72296bc736c1..d4c2c6394b77f3a3d5c424641f76998dad5440fd 100644
--- a/content/browser/quota/quota_database_unittest.cc
+++ b/content/browser/quota/quota_database_unittest.cc
@@ -294,6 +294,57 @@ class QuotaDatabaseTest : public testing::Test {
EXPECT_EQ(0U, origins.count(kOrigin3));
}
+ void OriginLastEvicted(const base::FilePath& kDbFile) {
+ QuotaDatabase db(kDbFile);
+ ASSERT_TRUE(db.LazyOpen(true));
+
+ const GURL kOrigin1("http://a/");
+ const GURL kOrigin2("http://b/");
+ const GURL kOrigin3("http://c/");
+
+ base::Time last_eviction_time;
+ EXPECT_TRUE(db.GetOriginLastEvictionTime(kOrigin1, kStorageTypeTemporary,
+ &last_eviction_time));
+ EXPECT_EQ(base::Time(), last_eviction_time);
michaeln 2015/10/13 21:35:36 thnx for the tests! also test DeleteOriginLastEvi
calamity 2015/10/15 07:56:43 Done.
+
+ // Report last eviction time for the test origins.
+ EXPECT_TRUE(db.SetOriginLastEvictionTime(
+ kOrigin1, kStorageTypeTemporary, base::Time::FromInternalValue(10)));
+ EXPECT_TRUE(db.SetOriginLastEvictionTime(
+ kOrigin2, kStorageTypeTemporary, base::Time::FromInternalValue(20)));
+ EXPECT_TRUE(db.SetOriginLastEvictionTime(
+ kOrigin3, kStorageTypeTemporary, base::Time::FromInternalValue(30)));
+
+ EXPECT_TRUE(db.GetOriginLastEvictionTime(kOrigin1, kStorageTypeTemporary,
+ &last_eviction_time));
+ EXPECT_EQ(base::Time::FromInternalValue(10), last_eviction_time);
+ EXPECT_TRUE(db.GetOriginLastEvictionTime(kOrigin2, kStorageTypeTemporary,
+ &last_eviction_time));
+ EXPECT_EQ(base::Time::FromInternalValue(20), last_eviction_time);
+ EXPECT_TRUE(db.GetOriginLastEvictionTime(kOrigin3, kStorageTypeTemporary,
+ &last_eviction_time));
+ EXPECT_EQ(base::Time::FromInternalValue(30), last_eviction_time);
+
+ // Delete last eviction times for the test origins.
+ EXPECT_TRUE(
+ db.DeleteOriginLastEvictionTime(kOrigin1, kStorageTypeTemporary));
+ EXPECT_TRUE(
+ db.DeleteOriginLastEvictionTime(kOrigin2, kStorageTypeTemporary));
+ EXPECT_TRUE(
+ db.DeleteOriginLastEvictionTime(kOrigin3, kStorageTypeTemporary));
+
+ last_eviction_time = base::Time();
+ EXPECT_TRUE(db.GetOriginLastEvictionTime(kOrigin1, kStorageTypeTemporary,
+ &last_eviction_time));
+ EXPECT_EQ(base::Time(), last_eviction_time);
+ EXPECT_TRUE(db.GetOriginLastEvictionTime(kOrigin2, kStorageTypeTemporary,
+ &last_eviction_time));
+ EXPECT_EQ(base::Time(), last_eviction_time);
+ EXPECT_TRUE(db.GetOriginLastEvictionTime(kOrigin3, kStorageTypeTemporary,
+ &last_eviction_time));
+ EXPECT_EQ(base::Time(), last_eviction_time);
+ }
+
void RegisterInitialOriginInfo(const base::FilePath& kDbFile) {
QuotaDatabase db(kDbFile);
@@ -541,6 +592,14 @@ TEST_F(QuotaDatabaseTest, OriginLastModifiedSince) {
OriginLastModifiedSince(base::FilePath());
}
+TEST_F(QuotaDatabaseTest, OriginLastEvicted) {
+ base::ScopedTempDir data_dir;
+ ASSERT_TRUE(data_dir.CreateUniqueTempDir());
+ const base::FilePath kDbFile = data_dir.path().AppendASCII(kDBFileName);
+ OriginLastEvicted(kDbFile);
+ OriginLastEvicted(base::FilePath());
+}
+
TEST_F(QuotaDatabaseTest, BootstrapFlag) {
base::ScopedTempDir data_dir;
ASSERT_TRUE(data_dir.CreateUniqueTempDir());

Powered by Google App Engine
This is Rietveld 408576698