Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 1403643003: Network transaction test for "Alt-Svc: clear" header. (Closed)

Created:
3 years ago by Bence
Modified:
3 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Network transaction test for "Alt-Svc: clear" header. This is a follow-up to https://crrev.com/1402633003. I verified locally that the test introduced in this CL fails if I revert https://crrev.com/1402633003. BUG=392575 Committed: https://crrev.com/4f5758595dc1f3555a37c2079524231077521c8b Cr-Commit-Position: refs/heads/master@{#354072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bence
Ryan: PTAL. Thanks.
3 years ago (2015-10-14 14:56:26 UTC) #2
Ryan Hamilton
LGTM. Out of curiosity, does clear work with Alternate-Protocol too?
3 years ago (2015-10-14 18:23:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403643003/1
3 years ago (2015-10-14 18:28:16 UTC) #5
Bence
On 2015/10/14 18:23:36, Ryan Hamilton wrote: > LGTM. Out of curiosity, does clear work with ...
3 years ago (2015-10-14 18:28:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years ago (2015-10-14 18:35:19 UTC) #7
commit-bot: I haz the power
3 years ago (2015-10-14 18:36:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f5758595dc1f3555a37c2079524231077521c8b
Cr-Commit-Position: refs/heads/master@{#354072}

Powered by Google App Engine
This is Rietveld 408576698