Rework list marker spacing for better web compatibility.

third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/ListMarkerPainter.h"
 
 #include "core/layout/LayoutListItem.h"
 #include "core/layout/LayoutListMarker.h"
 #include "core/layout/TextRunConstructor.h"
@@ skipping 40 matching lines @@
     if (m_layoutListMarker.isImage()) {
         context->drawImage(m_layoutListMarker.image()->image(&m_layoutListMarker, marker.size()).get(), marker);
         if (m_layoutListMarker.selectionState() != SelectionNone) {
             LayoutRect selRect = m_layoutListMarker.localSelectionRect();
             selRect.moveBy(boxOrigin);
             context->fillRect(pixelSnappedIntRect(selRect), m_layoutListMarker.listItem()->selectionBackgroundColor());
         }
         return;
     }
 
-    if (m_layoutListMarker.selectionState() != SelectionNone) {
+    if (!RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled()
+        && m_layoutListMarker.selectionState() != SelectionNone) {
         LayoutRect selRect = m_layoutListMarker.localSelectionRect();
         selRect.moveBy(boxOrigin);
         context->fillRect(pixelSnappedIntRect(selRect), m_layoutListMarker.listItem()->selectionBackgroundColor());
     }
 
+    // TODO(wkorman): Do we still need all of these if we use pure text?
     const Color color(m_layoutListMarker.resolveColor(CSSPropertyColor));
     context->setStrokeColor(color);
     context->setStrokeStyle(SolidStroke);
     context->setStrokeThickness(1.0f);
     context->setFillColor(color);
 
-    EListStyleType type = m_layoutListMarker.style()->listStyleType();
-    switch (type) {
-    case Disc:
-        context->fillEllipse(marker);
+    EListStyleType listStyle = m_layoutListMarker.style()->listStyleType();
+    if (listStyle == NoneListStyle)
         return;
-    case Circle:
-        context->strokeEllipse(marker);
-        return;
-    case Square:
-        context->fillRect(marker);
-        return;
-    case NoneListStyle:
-        return;
-    case ArabicIndic:
-    case Armenian:
-    case Bengali:
-    case Cambodian:
-    case CJKIdeographic:
-    case CjkEarthlyBranch:
-    case CjkHeavenlyStem:
-    case DecimalLeadingZero:
-    case DecimalListStyle:
-    case Devanagari:
-    case EthiopicHalehame:
-    case EthiopicHalehameAm:
-    case EthiopicHalehameTiEr:
-    case EthiopicHalehameTiEt:
-    case Georgian:
-    case Gujarati:
-    case Gurmukhi:
-    case Hebrew:
-    case Hangul:
-    case HangulConsonant:
-    case KoreanHangulFormal:
-    case KoreanHanjaFormal:
-    case KoreanHanjaInformal:
-    case Hiragana:
-    case HiraganaIroha:
-    case Kannada:
-    case Katakana:
-    case KatakanaIroha:
-    case Khmer:
-    case Lao:
-    case LowerAlpha:
-    case LowerArmenian:
-    case LowerGreek:
-    case LowerLatin:
-    case LowerRoman:
-    case Malayalam:
-    case Mongolian:
-    case Myanmar:
-    case Oriya:
-    case Persian:
-    case SimpChineseFormal:
-    case SimpChineseInformal:
-    case Telugu:
-    case Thai:
-    case Tibetan:
-    case TradChineseFormal:
-    case TradChineseInformal:
-    case UpperAlpha:
-    case UpperArmenian:
-    case UpperLatin:
-    case UpperRoman:
-    case Urdu:
-        break;
-    }
     if (m_layoutListMarker.text().isEmpty())
         return;
 
     const Font& font = m_layoutListMarker.style()->font();
     TextRun textRun = constructTextRun(font, m_layoutListMarker.text(), m_layoutListMarker.styleRef());
 
     GraphicsContextStateSaver stateSaver(*context, false);
     if (!m_layoutListMarker.style()->isHorizontalWritingMode()) {
         marker.moveBy(roundedIntPoint(-boxOrigin));
         marker = marker.transposedRect();
@@ skipping 14 matching lines @@
     StringBuilder reversedText;
     if (textNeedsReversing) {
         unsigned length = m_layoutListMarker.text().length();
         reversedText.reserveCapacity(length);
         for (int i = length - 1; i >= 0; --i)
             reversedText.append(m_layoutListMarker.text()[i]);
         ASSERT(reversedText.length() == length);
         textRun.setText(reversedText.toString());
     }
 
-    const UChar suffix = m_layoutListMarker.listMarkerSuffix(type, m_layoutListMarker.listItem()->value());
-    UChar suffixStr[2] = { suffix, static_cast<UChar>(' ') };
-    TextRun suffixRun = constructTextRun(font, suffixStr, 2, m_layoutListMarker.styleRef(), m_layoutListMarker.style()->direction());
+    const UChar suffix = m_layoutListMarker.listMarkerSuffix(listStyle, m_layoutListMarker.listItem()->value());
+    UChar suffixStr[2];
+    suffixStr[0] = suffix;
+    int suffixLength = 1;
+    // For lists with symbol style, the suffix is a space. For language styles, the suffix is a
+    // language-specific character which is then followed by an additional space.
+    // TODO(wkorman): Review everywhere we do this and see if we can consolidate logic.
+    if (m_layoutListMarker.simplifiedListStyle() == LayoutListMarker::LanguageSimpleStyle) {
+        suffixStr[1] = static_cast<UChar>(' ');
+        suffixLength = 2;
+    }
+    TextRun suffixRun = constructTextRun(font, suffixStr, suffixLength, m_layoutListMarker.styleRef(), m_layoutListMarker.style()->direction());
     TextRunPaintInfo suffixRunInfo(suffixRun);
     suffixRunInfo.bounds = marker;
 
     if (m_layoutListMarker.style()->isLeftToRightDirection()) {
         context->drawText(font, textRunPaintInfo, textOrigin);
         context->drawText(font, suffixRunInfo, textOrigin + IntSize(font.width(textRun), 0));
     } else {
         context->drawText(font, suffixRunInfo, textOrigin);
         context->drawText(font, textRunPaintInfo, textOrigin + IntSize(font.width(suffixRun), 0));
     }
 }
 
 } // namespace blink