Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1403633007: Remove stale references to --harmony-arrays flag in mjsunit tests (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove stale references to --harmony-arrays flag in mjsunit tests Also move those tests from mjsunit/harmony to mjsunit/es6. R=littledan@chromium.org Committed: https://crrev.com/e5db1d58e59dd51398faea25d11e6769a8512f98 Cr-Commit-Position: refs/heads/master@{#31314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1410 lines) Patch
A + test/mjsunit/es6/array-copywithin.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/array-fill.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/array-find.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/array-findindex.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/array-from.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/array-of.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/array-copywithin.js View 1 chunk +0 lines, -338 lines 0 comments Download
D test/mjsunit/harmony/array-fill.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/mjsunit/harmony/array-find.js View 1 chunk +0 lines, -318 lines 0 comments Download
D test/mjsunit/harmony/array-findindex.js View 1 chunk +0 lines, -318 lines 0 comments Download
D test/mjsunit/harmony/array-from.js View 1 chunk +0 lines, -179 lines 0 comments Download
D test/mjsunit/harmony/array-of.js View 1 chunk +0 lines, -214 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
adamk
5 years, 2 months ago (2015-10-15 13:43:03 UTC) #1
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-15 13:45:28 UTC) #2
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-15 13:45:29 UTC) #3
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-15 13:45:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403633007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403633007/1
5 years, 2 months ago (2015-10-15 13:45:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/10660)
5 years, 2 months ago (2015-10-15 15:32:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403633007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403633007/1
5 years, 2 months ago (2015-10-15 16:59:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 17:39:38 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 17:39:51 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e5db1d58e59dd51398faea25d11e6769a8512f98
Cr-Commit-Position: refs/heads/master@{#31314}

Powered by Google App Engine
This is Rietveld 408576698