Use standard DOM code definitions instead of custom.

Use standard DOM code definitions instead of custom.

This turns out to be a bit more churn than I'd hoped because ui/events/keycodes/dom/dom_code.h declares a strongly-typed enum, which can't be compared to unsigned int without a cast. Overall, I like the safety of typed enums, so I added the casts rather than declaring our own untyped equivalent, but LMK if you would prefer that.

Committed: https://crrev.com/aadc22f8398b451ed76da4183f05f72b0349f0bd
Cr-Commit-Position: refs/heads/master@{#353626}

[Jamie, 2015-10-10 01:27:01]

The CQ bit was checked by jamiewalch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-10 01:28:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403583003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403583003/1

[commit-bot: I haz the power, 2015-10-10 01:39:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-10 01:39:34]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jamie, 2015-10-12 17:21:12]

The CQ bit was checked by jamiewalch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-12 17:22:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403583003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403583003/20001

[commit-bot: I haz the power, 2015-10-12 17:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 17:32:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jamie, 2015-10-12 17:41:19]

The CQ bit was checked by jamiewalch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-12 17:42:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403583003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403583003/40001

[commit-bot: I haz the power, 2015-10-12 17:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 17:57:17]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jamie, 2015-10-12 18:05:57]

jamiewalch@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Jamie, 2015-10-12 18:05:58]

Having our own copy of these defintions makes less and less sense the more we
add. I need to add a couple more to fix
https://code.google.com/p/chromium/issues/detail?id=435411 so I decided to bite
the bullet and switch to the standard definitions.

[Jamie, 2015-10-12 18:11:44]

The CQ bit was checked by jamiewalch@chromium.org to run a CQ dry run

[Jamie, 2015-10-12 18:12:44]

jamiewalch@chromium.org changed reviewers:
+ danakj@chromium.org

[Jamie, 2015-10-12 18:12:44]

+danakj for DEPS

[commit-bot: I haz the power, 2015-10-12 18:13:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403583003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403583003/80001

[commit-bot: I haz the power, 2015-10-12 18:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 18:23:47]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[danakj, 2015-10-12 18:29:47]

I'm not a ui/events owner.

[Jamie, 2015-10-12 21:10:01]

jamiewalch@chromium.org changed reviewers:
+ garykac@chromium.org

[Jamie, 2015-10-12 21:10:02]

I think your LGTM is needed because the presubmit check thinks I've added ui/gfx
(actually I've only added a comma...)

+garykac for ui/events

[danakj, 2015-10-12 21:12:27]

no change LGTM :p

https://codereview.chromium.org/1403583003/diff/80001/remoting/test/DEPS
File remoting/test/DEPS (right):

https://codereview.chromium.org/1403583003/diff/80001/remoting/test/DEPS#newc...
remoting/test/DEPS:10: "+ui/events/keycodes/dom"
put a comma on here here then

[Sergey Ulanov, 2015-10-12 21:45:57]

lgtm, but please see my nits about uint32_t.

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
File remoting/client/normalizing_input_filter_cros.cc (right):

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
remoting/client/normalizing_input_filter_cros.cc:15: static bool
IsOsKey(unsigned int code) {
Change these helper functions to use uint32_t instead of unsigned int.

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
remoting/client/normalizing_input_filter_cros.cc:16: return code ==
static_cast<unsigned int>(ui::DomCode::OS_LEFT) ||
s/unsigned int/uint32_t/

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
File remoting/client/normalizing_input_filter_cros_unittest.cc (right):

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
remoting/client/normalizing_input_filter_cros_unittest.cc:29:
event.set_usb_keycode(static_cast<uint32>(keycode));
s/uint32/uint32_t/

https://codereview.chromium.org/1403583003/diff/80001/remoting/protocol/input...
File remoting/protocol/input_event_tracker.cc (right):

https://codereview.chromium.org/1403583003/diff/80001/remoting/protocol/input...
remoting/protocol/input_event_tracker.cc:33:
event.set_usb_keycode(static_cast<unsigned int>(keycode));
use uint32_t instead of unsigned int.

[Jamie, 2015-10-12 22:25:51]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-10-12 22:25:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1403583003/#ps100001
(title: "Reviewer feedback.")

[Jamie, 2015-10-12 22:26:09]

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
File remoting/client/normalizing_input_filter_cros.cc (right):

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
remoting/client/normalizing_input_filter_cros.cc:15: static bool
IsOsKey(unsigned int code) {
On 2015/10/12 21:45:57, Sergey Ulanov wrote:
> Change these helper functions to use uint32_t instead of unsigned int. 

Done.

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
remoting/client/normalizing_input_filter_cros.cc:16: return code ==
static_cast<unsigned int>(ui::DomCode::OS_LEFT) ||
On 2015/10/12 21:45:57, Sergey Ulanov wrote:
> s/unsigned int/uint32_t/

Done.

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
File remoting/client/normalizing_input_filter_cros_unittest.cc (right):

https://codereview.chromium.org/1403583003/diff/80001/remoting/client/normali...
remoting/client/normalizing_input_filter_cros_unittest.cc:29:
event.set_usb_keycode(static_cast<uint32>(keycode));
On 2015/10/12 21:45:57, Sergey Ulanov wrote:
> s/uint32/uint32_t/

Done.

https://codereview.chromium.org/1403583003/diff/80001/remoting/protocol/input...
File remoting/protocol/input_event_tracker.cc (right):

https://codereview.chromium.org/1403583003/diff/80001/remoting/protocol/input...
remoting/protocol/input_event_tracker.cc:33:
event.set_usb_keycode(static_cast<unsigned int>(keycode));
On 2015/10/12 21:45:57, Sergey Ulanov wrote:
> use uint32_t instead of unsigned int.

Done.

https://codereview.chromium.org/1403583003/diff/80001/remoting/test/DEPS
File remoting/test/DEPS (right):

https://codereview.chromium.org/1403583003/diff/80001/remoting/test/DEPS#newc...
remoting/test/DEPS:10: "+ui/events/keycodes/dom"
On 2015/10/12 21:12:27, danakj wrote:
> put a comma on here here then

Done.

[commit-bot: I haz the power, 2015-10-12 22:26:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403583003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403583003/100001

[commit-bot: I haz the power, 2015-10-12 22:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 22:36:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[garykac, 2015-10-12 22:50:33]

The CQ bit was checked by garykac@chromium.org

[garykac, 2015-10-12 22:50:33]

lgtm

[commit-bot: I haz the power, 2015-10-12 22:52:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403583003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403583003/100001

[commit-bot: I haz the power, 2015-10-12 23:26:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-12 23:27:04]

Patchset 6 (id:??) landed as
https://crrev.com/aadc22f8398b451ed76da4183f05f72b0349f0bd
Cr-Commit-Position: refs/heads/master@{#353626}