Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1403563004: Isolate gl_unittests_apk. (Closed)

Created:
5 years, 2 months ago by ghost stip (do not use)
Modified:
5 years, 2 months ago
Reviewers:
jbudorick, no sievers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate gl_unittests_apk. BUG=525873 Committed: https://crrev.com/8f277dc5f02f2c6e9de29dfa5707542918ca7427 Cr-Commit-Position: refs/heads/master@{#353878}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add gl_unittests_apk.isolate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M ui/gl/gl_tests.gyp View 1 chunk +22 lines, -1 line 0 comments Download
A + ui/gl/gl_unittests_apk.isolate View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ghost stip (do not use)
jbudorick: ptal sievers: OWNERS
5 years, 2 months ago (2015-10-13 04:59:03 UTC) #2
jbudorick
https://codereview.chromium.org/1403563004/diff/1/ui/gl/gl_tests.gyp File ui/gl/gl_tests.gyp (right): https://codereview.chromium.org/1403563004/diff/1/ui/gl/gl_tests.gyp#newcode84 ui/gl/gl_tests.gyp:84: 'gl_unittests_apk.isolate', This file doesn't exist and isn't in this ...
5 years, 2 months ago (2015-10-13 05:03:48 UTC) #3
jbudorick
lgtm
5 years, 2 months ago (2015-10-13 13:01:32 UTC) #4
no sievers
lgtm
5 years, 2 months ago (2015-10-13 20:17:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403563004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403563004/20001
5 years, 2 months ago (2015-10-13 20:58:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 22:29:11 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 22:29:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f277dc5f02f2c6e9de29dfa5707542918ca7427
Cr-Commit-Position: refs/heads/master@{#353878}

Powered by Google App Engine
This is Rietveld 408576698