Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1403503003: Bump default object id ring capacity (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bump default object id ring capacity Requested by IntelliJ who are running into issues with ids expiring too quickly. This is a temporary solution for 1.13 until we have a better id namespace for debuggers to use. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/5a3bace198ce51b6f06c49bc3b411589481623d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/object_id_ring.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
5 years, 2 months ago (2015-10-09 17:16:42 UTC) #3
turnidge
lgtm
5 years, 2 months ago (2015-10-12 16:51:50 UTC) #4
Cutch
5 years, 2 months ago (2015-10-12 17:32:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a3bace198ce51b6f06c49bc3b411589481623d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698