Delete best-effort keycode guessing.

Delete best-effort keycode guessing.

The logic to convert single-character compositions into synthetic
physical keyboard events is fairly complex and poses a risk of bugs.
Even with that logic, we still have to mix in a lot of other composition
events, so Javascript editing code still couldn't rely on receiving 100%
keycode events.  Simplify our behavior by forwarding IME events to Blink
with as little modification as possible.

BUG=

Committed: https://crrev.com/03a7f29bc37e1167d4a2499ceb13710beef5d1aa
Cr-Commit-Position: refs/heads/master@{#353446}

[aelias_OOO_until_Jul13, 2015-10-09 06:44:45]

aelias@chromium.org changed reviewers:
+ aurimas@chromium.org

[aelias_OOO_until_Jul13, 2015-10-09 06:44:52]

Hi aurimas@, PTAL.

[Changwan Ryu, 2015-10-09 12:34:27]

changwan@chromium.org changed reviewers:
+ changwan@chromium.org

[Changwan Ryu, 2015-10-09 12:34:28]

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java
(right):

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java:108:
public void testDeleteSurroundingText() throws Throwable {
Probably we should remove this test now. IMO this doesn't test anything.

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(left):

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:458:
assertEquals(KeyEvent.KEYCODE_H, mImeAdapter.mLastSyntheticKeyCode);
Can we separate this as testDeleteSurroundingText (except the last synthetic
keycode part)? We're missing such a test.

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:400:
@DisabledTest
Nit. Not disabled any more?

[aelias_OOO_until_Jul13, 2015-10-09 20:42:10]

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java
(right):

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java:108:
public void testDeleteSurroundingText() throws Throwable {
On 2015/10/09 at 12:34:28, Changwan Ryu wrote:
> Probably we should remove this test now. IMO this doesn't test anything.

Done.

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(left):

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:458:
assertEquals(KeyEvent.KEYCODE_H, mImeAdapter.mLastSyntheticKeyCode);
On 2015/10/09 at 12:34:28, Changwan Ryu wrote:
> Can we separate this as testDeleteSurroundingText (except the last synthetic
keycode part)? We're missing such a test.

Done, I brought back the relevant parts as "testDeleteText".

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
(right):

https://codereview.chromium.org/1403453002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java:400:
@DisabledTest
On 2015/10/09 at 12:34:28, Changwan Ryu wrote:
> Nit. Not disabled any more?

Done.

[aurimas (slooooooooow), 2015-10-10 00:46:07]

LGTM, thanks for getting rid of this.

[aelias_OOO_until_Jul13, 2015-10-10 00:48:32]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2015-10-10 00:49:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403453002/20001

[commit-bot: I haz the power, 2015-10-10 00:56:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-10 00:57:44]

Patchset 2 (id:??) landed as
https://crrev.com/03a7f29bc37e1167d4a2499ceb13710beef5d1aa
Cr-Commit-Position: refs/heads/master@{#353446}