Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 140343002: extensions: Relocate pref name constants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add missing include for mac Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "apps/app_load_service.h" 7 #include "apps/app_load_service.h"
8 #include "apps/app_restore_service.h" 8 #include "apps/app_restore_service.h"
9 #include "apps/saved_files_service.h" 9 #include "apps/saved_files_service.h"
10 #include "apps/shell_window.h" 10 #include "apps/shell_window.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 #include "content/public/browser/site_instance.h" 66 #include "content/public/browser/site_instance.h"
67 #include "content/public/browser/user_metrics.h" 67 #include "content/public/browser/user_metrics.h"
68 #include "content/public/browser/web_contents.h" 68 #include "content/public/browser/web_contents.h"
69 #include "content/public/browser/web_contents_view.h" 69 #include "content/public/browser/web_contents_view.h"
70 #include "content/public/browser/web_ui.h" 70 #include "content/public/browser/web_ui.h"
71 #include "content/public/browser/web_ui_data_source.h" 71 #include "content/public/browser/web_ui_data_source.h"
72 #include "extensions/browser/extension_error.h" 72 #include "extensions/browser/extension_error.h"
73 #include "extensions/browser/extension_registry.h" 73 #include "extensions/browser/extension_registry.h"
74 #include "extensions/browser/lazy_background_task_queue.h" 74 #include "extensions/browser/lazy_background_task_queue.h"
75 #include "extensions/browser/management_policy.h" 75 #include "extensions/browser/management_policy.h"
76 #include "extensions/browser/pref_names.h"
76 #include "extensions/browser/view_type_utils.h" 77 #include "extensions/browser/view_type_utils.h"
77 #include "extensions/common/constants.h" 78 #include "extensions/common/constants.h"
78 #include "extensions/common/extension.h" 79 #include "extensions/common/extension.h"
79 #include "extensions/common/extension_set.h" 80 #include "extensions/common/extension_set.h"
80 #include "extensions/common/feature_switch.h" 81 #include "extensions/common/feature_switch.h"
81 #include "extensions/common/manifest_handlers/background_info.h" 82 #include "extensions/common/manifest_handlers/background_info.h"
82 #include "extensions/common/manifest_handlers/incognito_info.h" 83 #include "extensions/common/manifest_handlers/incognito_info.h"
83 #include "grit/browser_resources.h" 84 #include "grit/browser_resources.h"
84 #include "grit/chromium_strings.h" 85 #include "grit/chromium_strings.h"
85 #include "grit/generated_resources.h" 86 #include "grit/generated_resources.h"
(...skipping 1008 matching lines...) Expand 10 before | Expand all | Expand 10 after
1094 warning_service_observer_.Add( 1095 warning_service_observer_.Add(
1095 ExtensionSystem::Get(profile)->warning_service()); 1096 ExtensionSystem::Get(profile)->warning_service());
1096 1097
1097 error_console_observer_.Add(ErrorConsole::Get(profile)); 1098 error_console_observer_.Add(ErrorConsole::Get(profile));
1098 1099
1099 base::Closure callback = base::Bind( 1100 base::Closure callback = base::Bind(
1100 &ExtensionSettingsHandler::MaybeUpdateAfterNotification, 1101 &ExtensionSettingsHandler::MaybeUpdateAfterNotification,
1101 AsWeakPtr()); 1102 AsWeakPtr());
1102 1103
1103 pref_registrar_.Init(profile->GetPrefs()); 1104 pref_registrar_.Init(profile->GetPrefs());
1104 pref_registrar_.Add(prefs::kExtensionInstallDenyList, callback); 1105 pref_registrar_.Add(pref_names::kInstallDenyList, callback);
1105 } 1106 }
1106 1107
1107 std::vector<ExtensionPage> 1108 std::vector<ExtensionPage>
1108 ExtensionSettingsHandler::GetInspectablePagesForExtension( 1109 ExtensionSettingsHandler::GetInspectablePagesForExtension(
1109 const Extension* extension, bool extension_is_enabled) { 1110 const Extension* extension, bool extension_is_enabled) {
1110 std::vector<ExtensionPage> result; 1111 std::vector<ExtensionPage> result;
1111 1112
1112 // Get the extension process's active views. 1113 // Get the extension process's active views.
1113 extensions::ProcessManager* process_manager = 1114 extensions::ProcessManager* process_manager =
1114 ExtensionSystem::Get(extension_service_->profile())->process_manager(); 1115 ExtensionSystem::Get(extension_service_->profile())->process_manager();
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
1242 extension_service_->EnableExtension(extension_id); 1243 extension_service_->EnableExtension(extension_id);
1243 } else { 1244 } else {
1244 ExtensionErrorReporter::GetInstance()->ReportError( 1245 ExtensionErrorReporter::GetInstance()->ReportError(
1245 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')), 1246 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')),
1246 true /* be noisy */); 1247 true /* be noisy */);
1247 } 1248 }
1248 requirements_checker_.reset(); 1249 requirements_checker_.reset();
1249 } 1250 }
1250 1251
1251 } // namespace extensions 1252 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698