Add MOV (register) to ARM integrated assembler.

Add MOV (register) to ARM integrated assembler.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=54dbbbaf7c3a791b25e9dd504f0c501875ae4530

[Karl, 2015-10-30 21:20:58]

Description was changed from

==========
Add MOV (register) to ARM integrated assembler.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add MOV (register) to ARM integrated assembler.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-10-30 21:20:58]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-10-30 21:47:02]

https://codereview.chromium.org/1403403009/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1403403009/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:632: default:
Do you mean for the default case to fallthrough?

https://codereview.chromium.org/1403403009/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:639: return setNeedsTextFixup();
The code below this is unreachable...

[Karl, 2015-10-30 22:15:31]

https://chromiumcodereview.appspot.com/1403403009/diff/20001/src/IceAssembler...
File src/IceAssemblerARM32.cpp (right):

https://chromiumcodereview.appspot.com/1403403009/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.cpp:632: default:
On 2015/10/30 21:47:02, stichnot wrote:
> Do you mean for the default case to fallthrough?

Hmm, must be inhaling too many fumes. Fixing to require text fixup.

https://chromiumcodereview.appspot.com/1403403009/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.cpp:639: return setNeedsTextFixup();
On 2015/10/30 21:47:02, stichnot wrote:
> The code below this is unreachable...

Apparently here is where I misplaced the default code. Removing.

[Jim Stichnoth, 2015-10-30 22:21:42]

lgtm

[Karl, 2015-10-30 22:26:37]

Committed patchset #3 (id:40001) manually as
54dbbbaf7c3a791b25e9dd504f0c501875ae4530 (presubmit successful).