Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1403403002: DevTools: Timeline warnings link to docs. Forced Recalc gets own warning (Closed)

Created:
5 years, 2 months ago by paulirish
Modified:
5 years, 2 months ago
Reviewers:
caseq, alph
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org, yurys+blink_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Timeline warnings link to docs. Forced Recalc gets own warning BUG= Committed: https://crrev.com/319bc5cd712597dcd5688cfcf5f6441500277f7d Cr-Commit-Position: refs/heads/master@{#355022}

Patch Set 1 #

Total comments: 10

Patch Set 2 : address feedback #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : rebase #

Patch Set 6 : test expectations #

Patch Set 7 : test expect #

Patch Set 8 : ya #

Patch Set 9 : newline ugh #

Patch Set 10 : . #

Messages

Total messages: 33 (15 generated)
paulirish
Is this the general approach you were thinking?
5 years, 2 months ago (2015-10-15 21:04:55 UTC) #2
caseq
looks mostly good, but here are a few style nits: https://codereview.chromium.org/1403403002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/1403403002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode1942 ...
5 years, 2 months ago (2015-10-15 21:20:57 UTC) #3
caseq
> indent by just 4 tabs I meant "4 spaces", of course :)
5 years, 2 months ago (2015-10-15 21:26:58 UTC) #4
paulirish
Thanks, super useful. PTAL https://codereview.chromium.org/1403403002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/1403403002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode1942 third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:1942: appendWarningRow: function(warningType, event){ On 2015/10/15 ...
5 years, 2 months ago (2015-10-16 02:16:27 UTC) #5
caseq
lgtm
5 years, 2 months ago (2015-10-16 18:48:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403403002/60001
5 years, 2 months ago (2015-10-16 18:48:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/118222)
5 years, 2 months ago (2015-10-16 19:54:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403403002/60001
5 years, 2 months ago (2015-10-16 20:52:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/121905)
5 years, 2 months ago (2015-10-16 21:56:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403403002/60001
5 years, 2 months ago (2015-10-19 19:18:31 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/128239)
5 years, 2 months ago (2015-10-19 20:46:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403403002/80001
5 years, 2 months ago (2015-10-19 20:49:59 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/122632)
5 years, 2 months ago (2015-10-19 22:10:24 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403403002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403403002/100001
5 years, 2 months ago (2015-10-20 01:32:43 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/122826)
5 years, 2 months ago (2015-10-20 02:45:57 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403403002/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403403002/170001
5 years, 2 months ago (2015-10-20 08:31:05 UTC) #31
commit-bot: I haz the power
Committed patchset #10 (id:170001)
5 years, 2 months ago (2015-10-20 09:42:59 UTC) #32
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 09:43:46 UTC) #33
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/319bc5cd712597dcd5688cfcf5f6441500277f7d
Cr-Commit-Position: refs/heads/master@{#355022}

Powered by Google App Engine
This is Rietveld 408576698