Issue 1403373018: Fix for regions reported with multiple targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1403373018: Fix for regions reported with multiple targets. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for regions reported with multiple targets. We should merge them into single NavigationRegion(s) with multiple targets. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7b75a53fefce112c2097deaa4656cf356544109b

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -7 lines)			Patch
M	pkg/analysis_server/lib/src/domains/analysis/navigation.dart	View	4 chunks	+19 lines, -6 lines	0 comments	Download
A	pkg/analysis_server/test/analysis/navigation_collector_test.dart	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/test_all.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 1 month ago (2015-10-28 23:38:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b75a53fefce112c2097deaa4656cf356544109b (presubmit successful).