Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1403373016: Fix debug mode test failures on MIPS and PPC after f1aa5562. (Closed)

Created:
5 years, 1 month ago by akos.palfi.imgtec
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix debug mode test failures on MIPS and PPC after f1aa5562. TEST=cctest/test-gap-resolver/FuzzResolver,unittests/MoveOptimizerTest.RemovesRedundantExplicit BUG= Committed: https://crrev.com/8eabcb3fb64449e719112b126af30e6768c2df41 Cr-Commit-Position: refs/heads/master@{#31629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M test/cctest/compiler/test-gap-resolver.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M test/unittests/compiler/move-optimizer-unittest.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
akos.palfi.imgtec
Hi Danno, This CL fixes two debug mode test failures on MIPS and PPC. The ...
5 years, 1 month ago (2015-10-28 11:57:58 UTC) #2
danno
lgtm
5 years, 1 month ago (2015-10-28 11:59:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403373016/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403373016/1
5 years, 1 month ago (2015-10-28 12:06:06 UTC) #5
akos.palfi.imgtec
5 years, 1 month ago (2015-10-28 12:14:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 13:04:18 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8eabcb3fb64449e719112b126af30e6768c2df41 Cr-Commit-Position: refs/heads/master@{#31629}
5 years, 1 month ago (2015-10-28 13:04:48 UTC) #9
MTBrandyberry
5 years, 1 month ago (2015-10-28 14:11:09 UTC) #10
Message was sent while issue was closed.
On 2015/10/28 11:57:58, akos.palfi.imgtec wrote:
> Hi Danno,
> 
> This CL fixes two debug mode test failures on MIPS and PPC. The
ExplicitOperand
> has a requirement that the register must be allocatable. These tests try to
use
> register 1 via ExplicitOperand, but this register is not allocatable on MIPS
and
> on PPC. I've modified the tests to use an allocatable register index, PTAL.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698