Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

Issue 1403373013: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 delete this._selectionToSet; 216 delete this._selectionToSet;
217 }, 217 },
218 218
219 _wasShownOrLoaded: function() 219 _wasShownOrLoaded: function()
220 { 220 {
221 this._innerRevealPositionIfNeeded(); 221 this._innerRevealPositionIfNeeded();
222 this._innerSetSelectionIfNeeded(); 222 this._innerSetSelectionIfNeeded();
223 this._innerScrollToLineIfNeeded(); 223 this._innerScrollToLineIfNeeded();
224 }, 224 },
225 225
226 /**
227 * @param {!WebInspector.TextRange} oldRange
228 * @param {!WebInspector.TextRange} newRange
229 */
226 onTextChanged: function(oldRange, newRange) 230 onTextChanged: function(oldRange, newRange)
227 { 231 {
228 if (this._searchResultsChangedCallback) 232 if (this._searchResultsChangedCallback)
229 this._searchResultsChangedCallback(); 233 this._searchResultsChangedCallback();
230 }, 234 },
231 235
232 /** 236 /**
233 * @param {string} content 237 * @param {string} content
234 * @param {string} mimeType 238 * @param {string} mimeType
235 * @return {string} 239 * @return {string}
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 * @constructor 602 * @constructor
599 */ 603 */
600 WebInspector.TextEditorDelegateForSourceFrame = function(sourceFrame) 604 WebInspector.TextEditorDelegateForSourceFrame = function(sourceFrame)
601 { 605 {
602 this._sourceFrame = sourceFrame; 606 this._sourceFrame = sourceFrame;
603 } 607 }
604 608
605 WebInspector.TextEditorDelegateForSourceFrame.prototype = { 609 WebInspector.TextEditorDelegateForSourceFrame.prototype = {
606 /** 610 /**
607 * @override 611 * @override
612 * @param {!WebInspector.TextRange} oldRange
613 * @param {!WebInspector.TextRange} newRange
608 */ 614 */
609 onTextChanged: function(oldRange, newRange) 615 onTextChanged: function(oldRange, newRange)
610 { 616 {
611 this._sourceFrame.onTextChanged(oldRange, newRange); 617 this._sourceFrame.onTextChanged(oldRange, newRange);
612 }, 618 },
613 619
614 /** 620 /**
615 * @override 621 * @override
616 * @param {!WebInspector.TextRange} textRange 622 * @param {!WebInspector.TextRange} textRange
617 */ 623 */
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 /** 662 /**
657 * @override 663 * @override
658 * @param {?WebInspector.TextRange} from 664 * @param {?WebInspector.TextRange} from
659 * @param {?WebInspector.TextRange} to 665 * @param {?WebInspector.TextRange} to
660 */ 666 */
661 onJumpToPosition: function(from, to) 667 onJumpToPosition: function(from, to)
662 { 668 {
663 this._sourceFrame.onJumpToPosition(from, to); 669 this._sourceFrame.onJumpToPosition(from, to);
664 } 670 }
665 } 671 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698