Add some empty classes for the embedded SharedWorker.

Add an empty class for the embedded SharedWorker.
(SharedWorkerServiceImpl)

These class will be used when "enable-embedded-shared-worker" is set.

BUG=327256
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251012

[horo, 2014-02-12 06:22:40]

kinuko@
Could you please review this CL?

[kinuko, 2014-02-12 08:09:49]

Some high-level comment:

content/browser/worker_host is for the 'host' code for worker process, I guess
we should rather start with creating a new directory like
content/browser/shared_worker (and add ourselves to its owner's file)?

Also it'd be probably preferred to add a new file one by one unless they're
referred in each other (e.g. I'd start with adding shared_worker_service)

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
File content/browser/worker_host/shared_worker_document_set.h (right):

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
content/browser/worker_host/shared_worker_document_set.h:13: namespace content {
nit: not mandatory or not in our style guide, but we usually put an empty line
after and before namespace { } (other than for forward-decls or for one-line
body etc)

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
content/browser/worker_host/shared_worker_document_set.h:19: // willall exit
when the last document in that set exits, per the WebWorkers
willall -> will all

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
content/browser/worker_host/shared_worker_document_set.h:21: // If
"enable-embedded-shared-worker" is set this class will be used in stead of
nit: 'in stead of' works, but 'instead of' might be more common (afaik 'in stead
of' is rarely used these days)

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
content/browser/worker_host/shared_worker_document_set.h:23: class
SharedWorkerDocumentSet
This class's mostly same as WorkerDocumentSet-- can I assume it'll evolve a lot
in a way that it becomes worth separating this out from WorkerDocumentSet, or is
it mostly because we want to use different MessageFilter class?

If the latter is the case I wonder if we could avoid using WorkerMessageFilter
type in the WorkerDocumentSet but use more abstract type like
BrowserMessageFilter, since (on my brief look) filter() of this class seems to
be used only for pointer comparison.

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
File content/browser/worker_host/shared_worker_host.cc (right):

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
content/browser/worker_host/shared_worker_host.cc:9: namespace content {
nit: ditto

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
File content/browser/worker_host/shared_worker_instance.h (right):

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
content/browser/worker_host/shared_worker_instance.h:15: namespace content {
ditto

[horo, 2014-02-12 08:43:44]

Removed shared_worker_document_set.* and moved others to
content/browser/shared_worker/

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
File content/browser/worker_host/shared_worker_host.cc (right):

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
content/browser/worker_host/shared_worker_host.cc:9: namespace content {
On 2014/02/12 08:09:49, kinuko wrote:
> nit: ditto

Done.

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
File content/browser/worker_host/shared_worker_instance.h (right):

https://codereview.chromium.org/140333011/diff/60001/content/browser/worker_h...
content/browser/worker_host/shared_worker_instance.h:15: namespace content {
On 2014/02/12 08:09:49, kinuko wrote:
> ditto

Done.

[kinuko, 2014-02-13 04:08:17]

Can we start with landing one central class, like SharedWorkerServiceImpl? I
can't see connections between these empty classes yet only from this patch, and
I wonder if you can add files when you actually add code which connects it to
the ones that are already submitted.

[horo, 2014-02-13 06:02:07]

On 2014/02/13 04:08:17, kinuko wrote:
> Can we start with landing one central class, like SharedWorkerServiceImpl? I
> can't see connections between these empty classes yet only from this patch,
and
> I wonder if you can add files when you actually add code which connects it to
> the ones that are already submitted.

Done

[kinuko, 2014-02-13 06:10:33]

lgtm

[horo, 2014-02-13 07:28:11]

jochen@
Could you please review?

[jochen (gone - plz use gerrit), 2014-02-13 08:57:50]

lgtm

[horo, 2014-02-13 09:24:43]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-02-13 09:25:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/horo@chromium.org/140333011/300001

[commit-bot: I haz the power, 2014-02-13 15:10:07]

Change committed as 251012