Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 140333004: x64: Fix clang complain error of unused private field. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: arm and ia32 fixes Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 GenerateFastApiCallBody(masm, 492 GenerateFastApiCallBody(masm,
493 optimization, 493 optimization,
494 argc, 494 argc,
495 receiver, 495 receiver,
496 true); 496 true);
497 } 497 }
498 498
499 499
500 class CallInterceptorCompiler BASE_EMBEDDED { 500 class CallInterceptorCompiler BASE_EMBEDDED {
501 public: 501 public:
502 CallInterceptorCompiler(CallStubCompiler* stub_compiler, 502 CallInterceptorCompiler(CallStubCompiler* stub_compiler, Register name)
503 const ParameterCount& arguments,
504 Register name)
505 : stub_compiler_(stub_compiler), 503 : stub_compiler_(stub_compiler),
506 arguments_(arguments),
507 name_(name) {} 504 name_(name) {}
508 505
509 void Compile(MacroAssembler* masm, 506 void Compile(MacroAssembler* masm,
510 Handle<JSObject> object, 507 Handle<JSObject> object,
511 Handle<JSObject> holder, 508 Handle<JSObject> holder,
512 Handle<Name> name, 509 Handle<Name> name,
513 LookupResult* lookup, 510 LookupResult* lookup,
514 Register receiver, 511 Register receiver,
515 Register scratch1, 512 Register scratch1,
516 Register scratch2, 513 Register scratch2,
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 __ pop(holder); 627 __ pop(holder);
631 __ pop(receiver); 628 __ pop(receiver);
632 // Leave the internal frame. 629 // Leave the internal frame.
633 } 630 }
634 631
635 __ cmp(eax, masm->isolate()->factory()->no_interceptor_result_sentinel()); 632 __ cmp(eax, masm->isolate()->factory()->no_interceptor_result_sentinel());
636 __ j(not_equal, interceptor_succeeded); 633 __ j(not_equal, interceptor_succeeded);
637 } 634 }
638 635
639 CallStubCompiler* stub_compiler_; 636 CallStubCompiler* stub_compiler_;
640 const ParameterCount& arguments_;
641 Register name_; 637 Register name_;
642 }; 638 };
643 639
644 640
645 void StoreStubCompiler::GenerateRestoreName(MacroAssembler* masm, 641 void StoreStubCompiler::GenerateRestoreName(MacroAssembler* masm,
646 Label* label, 642 Label* label,
647 Handle<Name> name) { 643 Handle<Name> name) {
648 if (!label->is_unused()) { 644 if (!label->is_unused()) {
649 __ bind(label); 645 __ bind(label);
650 __ mov(this->name(), Immediate(name)); 646 __ mov(this->name(), Immediate(name));
(...skipping 921 matching lines...) Expand 10 before | Expand all | Expand 10 after
1572 1568
1573 // Get the number of arguments. 1569 // Get the number of arguments.
1574 const int argc = arguments().immediate(); 1570 const int argc = arguments().immediate();
1575 1571
1576 LookupResult lookup(isolate()); 1572 LookupResult lookup(isolate());
1577 LookupPostInterceptor(holder, name, &lookup); 1573 LookupPostInterceptor(holder, name, &lookup);
1578 1574
1579 // Get the receiver from the stack. 1575 // Get the receiver from the stack.
1580 __ mov(edx, Operand(esp, (argc + 1) * kPointerSize)); 1576 __ mov(edx, Operand(esp, (argc + 1) * kPointerSize));
1581 1577
1582 CallInterceptorCompiler compiler(this, arguments(), ecx); 1578 CallInterceptorCompiler compiler(this, ecx);
1583 compiler.Compile(masm(), object, holder, name, &lookup, edx, ebx, edi, eax, 1579 compiler.Compile(masm(), object, holder, name, &lookup, edx, ebx, edi, eax,
1584 &miss); 1580 &miss);
1585 1581
1586 // Restore receiver. 1582 // Restore receiver.
1587 __ mov(edx, Operand(esp, (argc + 1) * kPointerSize)); 1583 __ mov(edx, Operand(esp, (argc + 1) * kPointerSize));
1588 1584
1589 GenerateJumpFunction(object, eax, &miss); 1585 GenerateJumpFunction(object, eax, &miss);
1590 1586
1591 HandlerFrontendFooter(&miss); 1587 HandlerFrontendFooter(&miss);
1592 1588
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
1961 // ----------------------------------- 1957 // -----------------------------------
1962 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1958 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1963 } 1959 }
1964 1960
1965 1961
1966 #undef __ 1962 #undef __
1967 1963
1968 } } // namespace v8::internal 1964 } } // namespace v8::internal
1969 1965
1970 #endif // V8_TARGET_ARCH_IA32 1966 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698