Issue 140333002: Roll (bis) swarming_client @ 361bfda6c0e4e2469dd3dab8c2b741639cacb086.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140333002: Roll (bis) swarming_client @ 361bfda6c0e4e2469dd3dab8c2b741639cacb086. (Closed)

Created:
6 years, 11 months ago by M-A Ruel

Modified:
6 years, 11 months ago

Reviewers:
Vadim Sh.

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Roll (bis) swarming_client @ 361bfda6c0e4e2469dd3dab8c2b741639cacb086. This rolls a single important commit for read only support. Remove read_only:1 from 'OS=="android"' in base_unittests.isolate. It is currently not supported. $ git log 8cacaaaffc..361bfda6 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//' 2014-01-15 maruel Change the default for isolate.py commands run & remap to copy files. R=vadimsh@chromium.org BUG=116251 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245043

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	base/base_unittests.isolate	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Android doesn't like the read_only flag because it expects hard links. It's fine, do not ...

6 years, 11 months ago (2014-01-16 00:08:09 UTC) #1

M-A Ruel

6 years, 11 months ago (2014-01-16 00:59:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r245043 (presubmit successful).

Expand Messages | Collapse Messages