Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1403313003: Remove params from Cacherator_GrTextureMaker (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove params from Cacherator_GrTextureMaker Committed: https://skia.googlesource.com/skia/+/5f5527fb46664297fbeb575033886a757eb44147

Patch Set 1 #

Total comments: 2

Patch Set 2 : correct_key #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -28 lines) Patch
M gm/image_pict.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkImageGenerator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkImageCacherator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageCacherator.cpp View 1 9 chunks +11 lines, -13 lines 0 comments Download
M src/core/SkImageGenerator.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkPictureImageGenerator.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/utils/SkImageGeneratorUtils.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bsalomon
https://codereview.chromium.org/1403313003/diff/1/src/core/SkImageCacherator.cpp File src/core/SkImageCacherator.cpp (right): https://codereview.chromium.org/1403313003/diff/1/src/core/SkImageCacherator.cpp#newcode227 src/core/SkImageCacherator.cpp:227: GrUniqueKey key; This gets cleaned up in a later ...
5 years, 2 months ago (2015-10-15 18:53:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403313003/1
5 years, 2 months ago (2015-10-15 18:54:03 UTC) #4
reed1
lgtm
5 years, 2 months ago (2015-10-15 18:57:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403313003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403313003/20001
5 years, 2 months ago (2015-10-15 19:05:35 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 19:15:02 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5f5527fb46664297fbeb575033886a757eb44147

Powered by Google App Engine
This is Rietveld 408576698