Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1403303011: AudioPlayer: Update control panel with playback progress bar. (Closed)

Created:
5 years, 1 month ago by fukino
Modified:
5 years, 1 month ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioPlayer: Update control panel with playback progress bar. This CL includes: - Replace custom progress bar with paper-slider. - Pause track temporalily while dragging progress bar to be consistent with video player. - Adjust layout of control panel. - Show playing time as "{current} / {duration}". BUG=488229 TEST=manually Committed: https://crrev.com/5c8f889bbbcc22b137b55e935e7d38f70c7e4ade Cr-Commit-Position: refs/heads/master@{#357064}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -206 lines) Patch
D ui/file_manager/audio_player/assets/100/player_timeline_base_center.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/100/player_timeline_base_left.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/100/player_timeline_base_right.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/100/player_timeline_handler_pressed.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/100/player_timeline_played_center.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/100/player_timeline_played_left.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/100/player_timeline_played_right.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/200/player_timeline_base_center.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/200/player_timeline_base_left.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/200/player_timeline_base_right.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/200/player_timeline_handler_pressed.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/200/player_timeline_played_center.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/200/player_timeline_played_left.png View Binary file 0 comments Download
D ui/file_manager/audio_player/assets/200/player_timeline_played_right.png View Binary file 0 comments Download
M ui/file_manager/audio_player/elements/audio_player.css View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/audio_player/elements/audio_player.js View 1 3 chunks +27 lines, -0 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.css View 1 3 chunks +23 lines, -169 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.html View 1 4 chunks +10 lines, -19 lines 0 comments Download
M ui/file_manager/audio_player/elements/control_panel.js View 3 chunks +27 lines, -11 lines 0 comments Download
M ui/file_manager/audio_player/elements/track_list.css View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/audio_player/js/background.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
fukino
PTAL. Thanks!
5 years, 1 month ago (2015-10-29 17:34:40 UTC) #2
yawano
https://codereview.chromium.org/1403303011/diff/1/ui/file_manager/audio_player/elements/audio_player.js File ui/file_manager/audio_player/elements/audio_player.js (right): https://codereview.chromium.org/1403303011/diff/1/ui/file_manager/audio_player/elements/audio_player.js#newcode408 ui/file_manager/audio_player/elements/audio_player.js:408: * Invoked then dragging state of seek bar on ...
5 years, 1 month ago (2015-10-30 01:59:54 UTC) #3
fukino
Thank you! https://codereview.chromium.org/1403303011/diff/1/ui/file_manager/audio_player/elements/audio_player.js File ui/file_manager/audio_player/elements/audio_player.js (right): https://codereview.chromium.org/1403303011/diff/1/ui/file_manager/audio_player/elements/audio_player.js#newcode408 ui/file_manager/audio_player/elements/audio_player.js:408: * Invoked then dragging state of seek ...
5 years, 1 month ago (2015-10-30 04:25:53 UTC) #4
yawano
lgtm. Thank you!
5 years, 1 month ago (2015-10-30 04:45:16 UTC) #5
fukino
On 2015/10/30 04:45:16, yawano wrote: > lgtm. Thank you! Thank you!
5 years, 1 month ago (2015-10-30 04:55:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403303011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403303011/20001
5 years, 1 month ago (2015-10-30 04:56:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 08:28:05 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5c8f889bbbcc22b137b55e935e7d38f70c7e4ade Cr-Commit-Position: refs/heads/master@{#357064}
5 years, 1 month ago (2015-10-30 08:29:15 UTC) #10
fukino
5 years, 1 month ago (2015-11-12 08:33:00 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1442583002/ by fukino@chromium.org.

The reason for reverting is: We decided to punt redesign of audio player to
M49..

Powered by Google App Engine
This is Rietveld 408576698