chrome/browser/extensions/webstore_inline_installer_factory.h - Issue 1403293008: Don't allow inline install if frame is deleted before user accepts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_inline_installer_factory.h

Issue 1403293008: Don't allow inline install if frame is deleted before user accepts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test compile failure Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer_browsertest.cc ('k') | chrome/browser/extensions/webstore_inline_installer_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_inline_installer_factory.h

diff --git a/chrome/browser/extensions/webstore_inline_installer_factory.h b/chrome/browser/extensions/webstore_inline_installer_factory.h

index b125741833585d660f50a2ae69ff29c7dc87f590..5b891cc8fa9f79eaf477597faa127e05c4ce18b2 100644

--- a/chrome/browser/extensions/webstore_inline_installer_factory.h

+++ b/chrome/browser/extensions/webstore_inline_installer_factory.h

@@ -12,7 +12,7 @@

#include "chrome/browser/extensions/webstore_standalone_installer.h"

namespace content {

- class WebContents;

+class WebContents;

}

class GURL;

@@ -28,6 +28,7 @@ class WebstoreInlineInstallerFactory {

// Create a new WebstoreInlineInstallerInstance to be owned by the caller.

virtual WebstoreInlineInstaller* CreateInstaller(

content::WebContents* contents,

+ content::RenderFrameHost* host,

const std::string& webstore_item_id,

const GURL& requestor_url,

const WebstoreStandaloneInstaller::Callback& callback);