Don't allow inline install if frame is deleted before user accepts

chrome/browser/extensions/webstore_inline_installer_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/extensions/webstore_inline_installer.h"
 #include "chrome/browser/extensions/webstore_inline_installer_factory.h"
 #include "chrome/browser/extensions/webstore_installer_test.h"
 #include "chrome/browser/extensions/webstore_standalone_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "url/gurl.h"
 
 using content::WebContents;
 
 namespace extensions {
 
+class WebstoreInlineInstallerForTest;
+
 namespace {
 
 const char kWebstoreDomain[] = "cws.com";
 const char kAppDomain[] = "app.com";
 const char kNonAppDomain[] = "nonapp.com";
 const char kTestExtensionId[] = "ecglahbcnmdpdciemllbhojghbkagdje";
 const char kTestDataPath[] = "extensions/api_test/webstore_inline_install";
 const char kCrxFilename[] = "extension.crx";
 
+class InstallerFactoryObserver {

[Devlin, 2015/11/05 17:40:40]

nit: I think this is a little more than we need.  Can the test factory itself
just store the last installer, and we can keep a raw ptr to the factory in the
test?

[asargent_no_longer_on_chrome, 2015/11/18 21:42:44]

Much simpler, I like it. Done. 

+ public:
+  virtual void OnInstallerCreated(
+      WebstoreInlineInstallerForTest* installer) = 0;
+};
+
 }  // namespace
 
-class WebstoreInlineInstallerTest : public WebstoreInstallerTest {
+class WebstoreInlineInstallerTest : public WebstoreInstallerTest,
+                                    public InstallerFactoryObserver {
  public:
   WebstoreInlineInstallerTest()
-      : WebstoreInstallerTest(
-            kWebstoreDomain,
-            kTestDataPath,
-            kCrxFilename,
-            kAppDomain,
-            kNonAppDomain) {}
+      : WebstoreInstallerTest(kWebstoreDomain,
+                              kTestDataPath,
+                              kCrxFilename,
+                              kAppDomain,
+                              kNonAppDomain),
+        last_installer_(nullptr) {}
+
+  void OnInstallerCreated(WebstoreInlineInstallerForTest* installer) override {
+    last_installer_ = installer;
+  }
+
+ protected:
+  WebstoreInlineInstallerForTest* last_installer_;
 };
 
 class ProgrammableInstallPrompt : public ExtensionInstallPrompt {
  public:
   explicit ProgrammableInstallPrompt(WebContents* contents)
       : ExtensionInstallPrompt(contents)
   {}
 
   ~ProgrammableInstallPrompt() override {}
 
@@ skipping 21 matching lines @@
   static Delegate* delegate_;
 };
 
 ExtensionInstallPrompt::Delegate* ProgrammableInstallPrompt::delegate_;
 
 // Fake inline installer which creates a programmable prompt in place of
 // the normal dialog UI.
 class WebstoreInlineInstallerForTest : public WebstoreInlineInstaller {
  public:
   WebstoreInlineInstallerForTest(WebContents* contents,
+                                 content::RenderFrameHost* host,
                                  const std::string& extension_id,
                                  const GURL& requestor_url,
                                  const Callback& callback)
-      : WebstoreInlineInstaller(
-            contents,
-            kTestExtensionId,
-            requestor_url,
-            base::Bind(DummyCallback)),
-        programmable_prompt_(NULL) {
-  }
+      : WebstoreInlineInstaller(contents,
+                                host,
+                                kTestExtensionId,
+                                requestor_url,
+                                base::Bind(DummyCallback)),
+        programmable_prompt_(NULL) {}
 
   scoped_ptr<ExtensionInstallPrompt> CreateInstallUI() override {
     programmable_prompt_ = new ProgrammableInstallPrompt(web_contents());
     return make_scoped_ptr(programmable_prompt_);
   }
 
+  bool CheckRequestorAlive() const override {
+    return WebstoreInlineInstaller::CheckRequestorAlive();

[Devlin, 2015/11/05 17:40:40]

Is this needed?

[asargent_no_longer_on_chrome, 2015/11/18 21:42:44]

It's just needed to make the method publicly visible so the test can call it
(it's a protected method of WebstoreInlineInstaller). 

Added a comment to this effect.

+  }
+
  private:
   ~WebstoreInlineInstallerForTest() override {}
 
   friend class base::RefCountedThreadSafe<WebstoreStandaloneInstaller>;
 
   static void DummyCallback(bool success,
                             const std::string& error,
                             webstore_install::Result result) {
   }
 
   ProgrammableInstallPrompt* programmable_prompt_;
 };
 
 class WebstoreInlineInstallerForTestFactory :
     public WebstoreInlineInstallerFactory {
+ public:
+  explicit WebstoreInlineInstallerForTestFactory(
+      InstallerFactoryObserver* observer)
+      : observer_(observer) {}
+
   ~WebstoreInlineInstallerForTestFactory() override {}
   WebstoreInlineInstaller* CreateInstaller(
       WebContents* contents,
+      content::RenderFrameHost* host,
       const std::string& webstore_item_id,
       const GURL& requestor_url,
       const WebstoreStandaloneInstaller::Callback& callback) override {
-    return new WebstoreInlineInstallerForTest(
-        contents, webstore_item_id, requestor_url, callback);
+    WebstoreInlineInstallerForTest* installer =
+        new WebstoreInlineInstallerForTest(contents, host, webstore_item_id,
+                                           requestor_url, callback);
+    observer_->OnInstallerCreated(installer);
+    return installer;
   }
+
+ protected:
+  InstallerFactoryObserver* observer_;
 };
 
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
                        CloseTabBeforeInstallConfirmation) {
   GURL install_url = GenerateTestServerUrl(kAppDomain, "install.html");
   ui_test_utils::NavigateToURL(browser(), install_url);
   WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   TabHelper* tab_helper = TabHelper::FromWebContents(web_contents);
   tab_helper->SetWebstoreInlineInstallerFactoryForTests(
-      new WebstoreInlineInstallerForTestFactory());
+      new WebstoreInlineInstallerForTestFactory(this));
   RunTestAsync("runTest");
   while (!ProgrammableInstallPrompt::Ready())
     base::RunLoop().RunUntilIdle();
   web_contents->Close();
   ProgrammableInstallPrompt::Accept();
 }
 
+IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
+                       NavigateBeforeInstallConfirmation) {
+  GURL install_url = GenerateTestServerUrl(kAppDomain, "install.html");
+  ui_test_utils::NavigateToURL(browser(), install_url);
+  WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  TabHelper* tab_helper = TabHelper::FromWebContents(web_contents);
+  tab_helper->SetWebstoreInlineInstallerFactoryForTests(
+      new WebstoreInlineInstallerForTestFactory(this));
+  RunTestAsync("runTest");
+  while (!ProgrammableInstallPrompt::Ready())
+    base::RunLoop().RunUntilIdle();
+  GURL new_url = GenerateTestServerUrl(kNonAppDomain, "empty.html");
+  web_contents->GetController().LoadURL(
+      new_url, content::Referrer(), ui::PAGE_TRANSITION_LINK, std::string());
+  EXPECT_TRUE(content::WaitForLoadStop(web_contents));
+  ASSERT_NE(last_installer_, nullptr);
+  EXPECT_NE(last_installer_->web_contents(), nullptr);
+  EXPECT_FALSE(last_installer_->CheckRequestorAlive());

[Devlin, 2015/11/05 17:40:40]

Can we also test inline installation from a frame, and navigating the frame? 
(If it seems like it'll be a pain, don't worry about it.)

[asargent_no_longer_on_chrome, 2015/11/18 21:42:44]

I wrote up a test for it, and in the process of trying to get the test working I
found out that we don't allow calling the API from frames! =)

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/renderer/ex...

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/renderer/ex...

+}
+
 // Flaky: https://crbug.com/537526.
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerTest,
                        DISABLED_ShouldBlockInlineInstallFromPopupWindow) {
   GURL install_url =
       GenerateTestServerUrl(kAppDomain, "install_from_popup.html");
   // Disable popup blocking for the test url.
   HostContentSettingsMapFactory::GetForProfile(browser()->profile())
       ->SetContentSetting(ContentSettingsPattern::FromURL(install_url),
                           ContentSettingsPattern::Wildcard(),
                           CONTENT_SETTINGS_TYPE_POPUPS,
@@ skipping 84 matching lines @@
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerListenerTest,
                        DownloadProgressListenerTest) {
   RunTest("download_progress_listener.html");
 }
 
 IN_PROC_BROWSER_TEST_F(WebstoreInlineInstallerListenerTest, BothListenersTest) {
   RunTest("both_listeners.html");
 }
 
 }  // namespace extensions