Issue 1403293006: Fix the dependencies for constant evaluation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1403293006: Fix the dependencies for constant evaluation (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson

Modified:
5 years, 2 months ago

Reviewers:
Paul Berry, scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix the dependencies for constant evaluation R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/763af3d14e77157438797fdeed6eecb1d827b352

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -13 lines)			Patch
	M	pkg/analyzer/lib/src/task/dart.dart	View		4 chunks	+21 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

I wasn't able to construct a test for this case; any suggestions are welcome.

5 years, 2 months ago (2015-10-22 20:05:03 UTC) #2

Brian Wilkerson

Committed patchset #1 (id:1) manually as 763af3d14e77157438797fdeed6eecb1d827b352 (presubmit successful).

5 years, 2 months ago (2015-10-22 20:52:59 UTC) #4

Paul Berry

5 years, 2 months ago (2015-10-23 15:19:23 UTC) #6

Message was sent while issue was closed.

Note: this CL caused a test breakage due to not rerunning the codegen step for
tasks.dot (see
http://build.chromium.org/p/client.dart/builders/pkg-linux-be/builds/1336/ste...).

Normally I would make a TBR commit to fix it, but it sounds like we are planning
on rolling back the change, so I'm leaving it as is for now.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages