Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1403283004: Revert of [es6] stage sticky regexps and RegExp.prototype.flags. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] stage sticky regexps and RegExp.prototype.flags. (patchset #3 id:40001 of https://codereview.chromium.org/1412133002/ ) Reason for revert: [sheriff] breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/4816 Original issue's description: > [es6] stage sticky regexps and RegExp.prototype.flags. > > R=littledan@chromium.org > BUG=v8:4342 > LOG=Y > > Committed: https://crrev.com/722719fe31fe7fd5bb50be6256b3581bb28a8169 > Cr-Commit-Position: refs/heads/master@{#31390} TBR=littledan@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4342 Committed: https://crrev.com/182ea8ad3f21cf381112f562c5fb6fa80e605d98 Cr-Commit-Position: refs/heads/master@{#31398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M src/flag-definitions.h View 2 chunks +5 lines, -5 lines 0 comments Download
M test/test262/test262.status View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [es6] stage sticky regexps and RegExp.prototype.flags.
5 years, 2 months ago (2015-10-20 07:53:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403283004/1
5 years, 2 months ago (2015-10-20 07:53:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 07:53:29 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 07:53:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/182ea8ad3f21cf381112f562c5fb6fa80e605d98
Cr-Commit-Position: refs/heads/master@{#31398}

Powered by Google App Engine
This is Rietveld 408576698