Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: ui/views/controls/webview/BUILD.gn

Issue 1403283002: Aura on Android: UnhandledKeyboardEventHandler::HandleNativeKeyboardEvent implementaion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_events
Patch Set: Getting rid of the use_aura condition. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/webview/webview.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/webview/BUILD.gn
diff --git a/ui/views/controls/webview/BUILD.gn b/ui/views/controls/webview/BUILD.gn
index ddb380d3379f7e3b69be772db9494cc3c148a943..30bda0da5ec525da46ef09f84f4c13504fd5b0a2 100644
--- a/ui/views/controls/webview/BUILD.gn
+++ b/ui/views/controls/webview/BUILD.gn
@@ -39,6 +39,10 @@ component("webview") {
"//ui/gfx/geometry",
"//ui/views",
]
+
+ if (is_android) {
+ sources += [ "unhandled_keyboard_event_handler_linux.cc" ]
no sievers 2015/10/15 22:14:43 Mind just duplicating the file since it's only one
mfomitchev 2015/10/16 17:27:58 I'd rather not. IMHO a little bit of build config
no sievers 2015/10/16 18:01:26 Sharing is fine, but then it shouldn't be called '
mfomitchev 2015/10/16 20:22:57 Yeah, I brought that up as well. I'd be happy to c
sky 2015/10/16 20:36:44 I'm ok with renaming to default.
mfomitchev 2015/10/20 20:52:03 Done.
+ }
}
source_set("test_support") {
« no previous file with comments | « no previous file | ui/views/controls/webview/webview.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698