Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 140323020: remove GM expectations for all ASAN/Valgrind builders (Closed)

Created:
6 years, 10 months ago by epoger
Modified:
6 years, 10 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

remove GM expectations for all ASAN/Valgrind builders BUG=skia:2112 NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21657 lines) Patch
M expectations/gm/Test-Ubuntu12-ShuttleA-HD2000-x86_64-Release-Valgrind/expected-results.json View 1 chunk +1 line, -9168 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 1 chunk +1 line, -12489 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
The long-term fix is https://code.google.com/p/skia/issues/detail?id=1711#c5 , but in the meanwhile, greenify the ASAN builder so ...
6 years, 10 months ago (2014-01-30 21:56:39 UTC) #1
borenet
LGTM assuming we don't think these builders will catch any interesting bugs when they have ...
6 years, 10 months ago (2014-01-30 21:58:22 UTC) #2
epoger
On 2014/01/30 21:58:22, borenet wrote: > LGTM assuming we don't think these builders will catch ...
6 years, 10 months ago (2014-01-30 22:00:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/140323020/1
6 years, 10 months ago (2014-01-30 22:00:49 UTC) #4
commit-bot: I haz the power
Change committed as 13248
6 years, 10 months ago (2014-01-30 22:00:58 UTC) #5
borenet
6 years, 10 months ago (2014-01-30 22:01:49 UTC) #6
Message was sent while issue was closed.
On 2014/01/30 22:00:12, epoger wrote:
> On 2014/01/30 21:58:22, borenet wrote:
> > LGTM assuming we don't think these builders will catch any interesting bugs
> when
> > they have expectations vs when they don't.
> 
> Right.  Discussion in these bugs led to that conclusion:
> 
> https://code.google.com/p/skia/issues/detail?id=1711 ('gm: on some builders,
> just run the gms, no need to check against expectations')
> https://code.google.com/p/skia/issues/detail?id=1824 ('dashing3_gpu
> ExpectationsMismatch on Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN')

SGTM

Powered by Google App Engine
This is Rietveld 408576698