Ash:Shelf - Cleanup of Alternate Shelf (part 1)

ash/system/web_notification/web_notification_tray.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/web_notification/web_notification_tray.h"
 
 #include "ash/ash_switches.h"
 #include "ash/root_window_controller.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shelf/shelf_layout_manager_observer.h"
@@ skipping 110 matching lines @@
   system_tray_height_ = height;
 
   // If the shelf is shown during auto-hide state, the distance from the edge
   // should be reduced by the height of shelf's shown height.
   if (shelf_ && shelf_->visibility_state() == SHELF_AUTO_HIDE &&
       shelf_->auto_hide_state() == SHELF_AUTO_HIDE_SHOWN) {
     system_tray_height_ -= ShelfLayoutManager::GetPreferredShelfSize() -
         ShelfLayoutManager::kAutoHideSize;
   }
 
-  if (system_tray_height_ > 0 && ash::switches::UseAlternateShelfLayout())
+  if (system_tray_height_ > 0)
     system_tray_height_ += message_center::kMarginBetweenItems;
 
   if (!shelf_)
     return;
 
   OnAutoHideStateChanged(shelf_->auto_hide_state());
 }
 
 void WorkAreaObserver::StartObserving(
     message_center::MessagePopupCollection* collection,
@@ skipping 71 matching lines @@
     views::TrayBubbleView::InitParams init_params =
         bubble->GetInitParams(anchor_alignment);
     views::View* anchor = tray->tray_container();
     if (anchor_alignment == views::TrayBubbleView::ANCHOR_ALIGNMENT_BOTTOM) {
       gfx::Point bounds(anchor->width() / 2, 0);
       views::View::ConvertPointToWidget(anchor, &bounds);
       init_params.arrow_offset = bounds.x();
     }
     views::TrayBubbleView* bubble_view = views::TrayBubbleView::Create(
         tray->GetBubbleWindowContainer(), anchor, tray, &init_params);
-    if (ash::switches::UseAlternateShelfLayout())
-      bubble_view->SetArrowPaintType(views::BubbleBorder::PAINT_NONE);
+    bubble_view->SetArrowPaintType(views::BubbleBorder::PAINT_NONE);
     bubble_wrapper_.reset(new TrayBubbleWrapper(tray, bubble_view));
     bubble->InitializeContents(bubble_view);
   }
 
   message_center::MessageBubbleBase* bubble() const { return bubble_.get(); }
 
   // Convenience accessors.
   views::TrayBubbleView* bubble_view() const { return bubble_->bubble_view(); }
 
  private:
@@ skipping 96 matching lines @@
 
 bool WebNotificationTray::ShowMessageCenterInternal(bool show_settings) {
   if (!ShouldShowMessageCenter())
     return false;
 
   should_block_shelf_auto_hide_ = true;
   message_center::MessageCenterBubble* message_center_bubble =
       new message_center::MessageCenterBubble(
           message_center(),
           message_center_tray_.get(),
-          ash::switches::UseAlternateShelfLayout());
+          true);

[James Cook, 2014/01/23 18:02:35]

same question about first_item_has_no_margin

[Harry McCleave, 2014/01/24 22:48:47]

.

 
   int max_height = 0;
   aura::Window* status_area_window = status_area_widget()->GetNativeView();
   switch (GetShelfLayoutManager()->GetAlignment()) {
     case SHELF_ALIGNMENT_BOTTOM: {
       gfx::Rect shelf_bounds = GetShelfLayoutManager()->GetIdealBounds();
       max_height = shelf_bounds.y();
       break;
     }
     case SHELF_ALIGNMENT_TOP: {
@@ skipping 50 matching lines @@
 bool WebNotificationTray::ShowPopups() {
   if (message_center_bubble())
     return false;
 
   popup_collection_.reset(new message_center::MessagePopupCollection(
       ash::Shell::GetContainer(
           GetWidget()->GetNativeView()->GetRootWindow(),
           internal::kShellWindowId_StatusContainer),
       message_center(),
       message_center_tray_.get(),
-      ash::switches::UseAlternateShelfLayout()));
+      true));
   work_area_observer_->StartObserving(
       popup_collection_.get(), GetWidget()->GetNativeView()->GetRootWindow());
   return true;
 }
 
 void WebNotificationTray::HidePopups() {
   DCHECK(popup_collection_.get());
 
   popup_collection_->MarkAllPopupsShown();
   popup_collection_.reset();
@@ skipping 198 matching lines @@
 
 message_center::MessageCenterBubble*
 WebNotificationTray::GetMessageCenterBubbleForTest() {
   if (!message_center_bubble())
     return NULL;
   return static_cast<message_center::MessageCenterBubble*>(
       message_center_bubble()->bubble());
 }
 
 }  // namespace ash