Ash:Shelf - Cleanup of Alternate Shelf (part 1)

ash/shelf/app_list_button.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELF_APP_LIST_BUTTON_H_
 #define ASH_SHELF_APP_LIST_BUTTON_H_
 
 #include "ui/views/controls/button/image_button.h"
 
 namespace ash {
+
+class ShelfWidget;
+
 namespace internal {
 
 class ShelfButtonHost;
 
 // Button used for the AppList icon on the shelf.
 class AppListButton : public views::ImageButton {

[James Cook, 2014/01/23 18:02:35]

It looks like you deleted the old app_list_button.h and then renamed
alternate_app_list_button.h to app_list_button.h.  Unfortunately git and
reitveld don't understand that; they think you just modified app_list_button.h.
This will lose revision history.

It's up to you how to resolve this. I think there are two approaches:
* Just decide the revision history of alternate_app_list_button.h/cc isn't
important and do what you do here
* Break this CL into two patches. In the first one delete app_list_button.h/cc. 
In the second one rename alternate_app_list_button.h/cc to app_list_button.h/cc.

What do you think?

[Harry McCleave, 2014/01/24 22:48:47]

This is the case, I don't think there is any meaningful history in the
alternate_ files as they have only existed for 1 or 2 changes, so I would vote
for just letting those changes get compressed into this one in the history, if
you disagree I will split this into 2 changes (rm app_list_button, then mv).

[James Cook, 2014/01/25 00:12:14]

In that case, keep it in one change. I just wanted to check that we weren't
losing anything significant.

  public:
-  AppListButton(views::ButtonListener* listener, ShelfButtonHost* host);
+  // Bounds size (inset) required for the app icon image (in pixels).
+  static const int kImageBoundsSize;
+
+  AppListButton(views::ButtonListener* listener,
+                ShelfButtonHost* host,
+                ShelfWidget* shelf_widget);
   virtual ~AppListButton();
 
-  void StartLoadingAnimation();
-  void StopLoadingAnimation();
-
  protected:
-  // views::ImageButton:
+  // views::ImageButton overrides:
   virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
   virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;
   virtual void OnMouseCaptureLost() OVERRIDE;
   virtual bool OnMouseDragged(const ui::MouseEvent& event) OVERRIDE;
   virtual void OnMouseMoved(const ui::MouseEvent& event) OVERRIDE;
   virtual void OnMouseEntered(const ui::MouseEvent& event) OVERRIDE;
   virtual void OnMouseExited(const ui::MouseEvent& event) OVERRIDE;
+  virtual void OnPaint(gfx::Canvas* canvas) OVERRIDE;
   virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
 
+  // ui::EventHandler overrides:
+  virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
+
  private:
   ShelfButtonHost* host_;
+  // Reference to the shelf widget containing this button, owned by the
+  // root window controller.
+  ShelfWidget* shelf_widget_;
 
   DISALLOW_COPY_AND_ASSIGN(AppListButton);
 };
 
 }  // namespace internal
 }  // namespace ash
 
 #endif  // ASH_SHELF_APP_LIST_BUTTON_H_