Index: chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm |
diff --git a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm |
index 7341835b372e3527306b29bcf4a07474317b3d93..8bad0bf0a7bba2273bc901a6c3d7e8717751980f 100644 |
--- a/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm |
+++ b/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm |
@@ -17,6 +17,8 @@ |
#include "ui/base/l10n/l10n_util_mac.h" |
#include "ui/base/ui_base_types.h" |
+const int kMessageTextMaxRows = 32; |
+ |
// Helper object that receives the notification that the dialog/sheet is |
// going away. Is responsible for cleaning itself up. |
@interface JavaScriptAppModalDialogHelper : NSObject<NSAlertDelegate> { |
@@ -146,6 +148,18 @@ JavaScriptAppModalDialogCocoa::JavaScriptAppModalDialogCocoa( |
[alert_ setDelegate:helper_]; |
NSString* informative_text = |
base::SysUTF16ToNSString(dialog_->message_text()); |
+ |
+ // Truncate long JS alerts - crbug.com/331219 |
+ NSArray * info_array = |
Avi (use Gerrit)
2014/01/23 02:58:30
style nit: no space before the *.
|
+ [informative_text componentsSeparatedByCharactersInSet: |
+ [NSCharacterSet newlineCharacterSet]]; |
+ if ([info_array count] > kMessageTextMaxRows) { |
+ info_array = [info_array subarrayWithRange:NSMakeRange( |
+ 0, kMessageTextMaxRows)]; |
+ informative_text = [info_array componentsJoinedByString:@"\n"]; |
+ informative_text = [informative_text stringByAppendingString:@"\n..."]; |
+ } |
+ |
[alert_ setInformativeText:informative_text]; |
NSString* message_text = |
base::SysUTF16ToNSString(dialog_->title()); |